All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org,  Emily Shaffer <nasamuffin@google.com>
Subject: Re: [PATCH] MyFirstContribution: move preparation of v2 after review discussion
Date: Tue, 20 Oct 2026 09:32:40 -0700	[thread overview]
Message-ID: <xmqqbj8oxrh3.fsf@gitster.g> (raw)
In-Reply-To: <atd7xT6Vj59omtuN@pks.im> (Patrick Steinhardt's message of "Tue, 20 Oct 2026 16:33:41 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> Nit: I think this would have been easier to review if you first moved
> stuff around without changing the language yet and only then changing it
> in a second commit. Like this it's basically impossible to see what was
> moved and what needs reviewing.

Yeah, I was thinking exactly that after sending it out.  Will do so
when I try it again after sleeping on the topic for a few days and
seeing other comments that hopefully will come in the meantime.

Thanks.


  reply	other threads:[~2026-10-20 16:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 20:43 [PATCH] MyFirstContribution: move preparation of v2 after review discussion Junio C Hamano
2026-10-20 14:33 ` Patrick Steinhardt
2026-10-20 16:32   ` Junio C Hamano [this message]
2026-10-20 23:22 ` [PATCH v2 0/2] MyFirstContribution: discuss then reroll Junio C Hamano
2026-10-20 23:22   ` [PATCH v2 1/2] MyFirstContribution: move "how to send v2" after discussing reviews Junio C Hamano
2026-10-20 23:22   ` [PATCH v2 2/2] MyFirstContribution: clarify that "reviewing" is a discussion Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbj8oxrh3.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nasamuffin@google.com \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.