All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com>
Cc: git@vger.kernel.org,  ps@pks.i
Subject: Re: [RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests
Date: Tue, 13 Jan 2026 05:40:51 -0800	[thread overview]
Message-ID: <xmqqbjixljfg.fsf@gitster.g> (raw)
In-Reply-To: <20260113100145.436591-1-shreyanshpaliwalcmsmn@gmail.com> (Shreyansh Paliwal's message of "Tue, 13 Jan 2026 15:23:55 +0530")

Shreyansh Paliwal <shreyanshpaliwalcmsmn@gmail.com> writes:

> I think a much better approach, is to use test-tool pkt-line pack,
> which I believe handles the formatting issues internally,

And more importantly, that is a tool specifically designed for this
kind of thing.  Very nicely spotted indeed.


  reply	other threads:[~2026-01-13 13:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-11 20:00 [RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests Shreyansh Paliwal
2026-01-11 22:50 ` Junio C Hamano
2026-01-12  8:21   ` Shreyansh Paliwal
2026-01-12  8:25   ` Patrick Steinhardt
2026-01-12  9:11     ` t5500-fetch-pack.sh and exit-code suppression Shreyansh Paliwal
2026-01-12 13:25     ` [RFC PATCH] t5500-fetch-pack.sh: fix suppression of Git exit code in tests Junio C Hamano
2026-01-13  9:53       ` Shreyansh Paliwal
2026-01-13 13:40         ` Junio C Hamano [this message]
2026-01-13 17:53           ` [GSOC][PATCH] t5500: simplify test implementation and fix git exit code suppression Shreyansh Paliwal
2026-01-15 21:28             ` Shreyansh Paliwal
2026-01-20 16:44             ` Junio C Hamano
2026-01-21 12:54               ` [GSOC][PATCH V2] " Shreyansh Paliwal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbjixljfg.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.i \
    --cc=shreyanshpaliwalcmsmn@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.