All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Karthik Nayak <karthik.188@gmail.com>
Cc: git@vger.kernel.org,  Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH 1/4] editorconfig: set maximum line length to 120 characters
Date: Thu, 26 Jun 2025 07:25:09 -0700	[thread overview]
Message-ID: <xmqqbjqar35m.fsf@gitster.g> (raw)
In-Reply-To: <CAOLa=ZRu-fBsNpoSzb8z2xUfM7WUUcdR1XRd8zr1U+P61QRccA@mail.gmail.com> (Karthik Nayak's message of "Thu, 26 Jun 2025 08:27:59 +0000")

Karthik Nayak <karthik.188@gmail.com> writes:

> So my intent was to instead was to allow the user to be in charge of
> line-wrapping, but for no reason should that go beyond 120 columns.
>
> I'm happy to change that to 80 columns, this does mean that supported
> editors will start wrapping at 80 columns. Users will have to override
> as necessary.

OK.  So stepping back a bit

 1. We advise people to avoid exceeding 80 columns

 2. A line can be easier to read without wrapping strictly at 80
    columns but left as a single line, slightly going above the
    limit..

 3. Even with the second observation above, a line that is way
    longer than 80 columns is not acceptably long.

Now, what is the line between the #2 and #3?  If we set these "hard
limit" to that number, as long as the tool does not pack multiple
shorter lines into one line using that number as a limit, we'd be at
a happy place, I would imagine?

Thanks.

  reply	other threads:[~2025-06-26 14:25 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-25 16:43 [PATCH 0/4] clang-format: modify rules to reduce false-positives Karthik Nayak
2025-06-25 16:43 ` [PATCH 1/4] editorconfig: set maximum line length to 120 characters Karthik Nayak
2025-06-25 18:41   ` Junio C Hamano
2025-06-26  8:27     ` Karthik Nayak
2025-06-26 14:25       ` Junio C Hamano [this message]
2025-06-27  8:38         ` Karthik Nayak
2025-06-26 16:22   ` Justin Tobler
2025-06-27  8:51     ` Karthik Nayak
2025-06-27 15:12       ` Justin Tobler
2025-06-30  8:29         ` Karthik Nayak
2025-06-25 16:43 ` [PATCH 2/4] clang-format: set 'ColumnLimit' to 0 Karthik Nayak
2025-06-25 16:43 ` [PATCH 3/4] clang-format: add 'RemoveBracesLLVM' to the main config Karthik Nayak
2025-06-25 16:43 ` [PATCH 4/4] meson: add rule to run 'git clang-format' Karthik Nayak
2025-06-26 16:35   ` Justin Tobler
2025-06-27  8:12     ` Karthik Nayak
2025-06-27 14:25       ` Junio C Hamano
2025-06-30  8:34         ` Karthik Nayak
2025-06-30 15:24           ` Junio C Hamano
2025-06-30  8:38 ` [PATCH v2 0/3] clang-format: modify rules to reduce false-positives Karthik Nayak
2025-06-30  8:38   ` [PATCH v2 1/3] clang-format: set 'ColumnLimit' to 0 Karthik Nayak
2025-06-30  8:38   ` [PATCH v2 2/3] clang-format: add 'RemoveBracesLLVM' to the main config Karthik Nayak
2025-06-30  8:38   ` [PATCH v2 3/3] meson: add rule to run 'git clang-format' Karthik Nayak
2025-07-01 10:13     ` Patrick Steinhardt
2025-07-01 15:08       ` Karthik Nayak
2025-07-01 16:02       ` Junio C Hamano
2025-07-01 13:26     ` Toon Claes
2025-07-01 15:12       ` Karthik Nayak
2025-07-02  2:54         ` Patrick Steinhardt
2025-06-30 15:27   ` [PATCH v2 0/3] clang-format: modify rules to reduce false-positives Junio C Hamano
2025-07-01 13:36   ` Toon Claes
2025-07-01 15:19     ` Karthik Nayak
2025-07-01 20:49     ` Junio C Hamano
2025-07-02  9:23 ` [PATCH v3 " Karthik Nayak
2025-07-02  9:23   ` [PATCH v3 1/3] clang-format: set 'ColumnLimit' to 0 Karthik Nayak
2025-07-02  9:23   ` [PATCH v3 2/3] clang-format: add 'RemoveBracesLLVM' to the main config Karthik Nayak
2025-07-02  9:23   ` [PATCH v3 3/3] meson: add rule to run 'git clang-format' Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbjqar35m.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=karthik.188@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.