All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Aditya Garg <gargaditya08@live.com>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>,
	 Julian Swagemakers <julian@swagemakers.org>,
	 Eric Sunshine <sunshine@sunshineco.com>,
	 Zi Yao <ziyao@disroot.org>,
	 Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
	 "sandals@crustytoothpaste.net" <sandals@crustytoothpaste.net>,
	 Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH v5 2/4] docs: improve formatting in git-send-email documentation
Date: Fri, 30 May 2025 10:15:59 -0700	[thread overview]
Message-ID: <xmqqbjraf29c.fsf@gitster.g> (raw)
In-Reply-To: <PN3PR01MB9597DEE8C41CB1599B9A97CEB861A@PN3PR01MB9597.INDPRD01.PROD.OUTLOOK.COM> (Aditya Garg's message of "Fri, 30 May 2025 13:32:14 +0000")

Aditya Garg <gargaditya08@live.com> writes:

>> But I do not see any link in ...
>> 
>>>>> -    by 'c_rehash', or a single file containing one or more PEM format
>>>>> -    certificates concatenated together: see verify(1) -CAfile and
>>>>> -    -CApath for more information on these). Set it to an empty string
>> 
>> ... the text that was removed.  The reference to verify(1) is a
>> command in the OpenSSL suite, right?
>
> If this is a command, its not phrased nicely imo. I'll just leave it as is.

In any case, there isn't an link in the document that is dangling,
is there?  It is not like I am trying to prove you wrong.  I am
trying to see if the change you made is still addressing a valid
concern, and if so if there is a way to make the result better,
possibly in some other ways.

I agree with you that this passage is not nice to expect that the
readers are familiar with what appears in

    https://docs.openssl.org/master/man1/openssl-verify/

where `-CAfile` and `-CApath` are two of the command line options
described there and has "more information on these".  The
description of these options on that page redirects us to

    https://docs.openssl.org/master/man1/openssl-verification-options/

and expects us to scroll down to #trusted-certificate-options
anchor, which is doubly unnice, but that part is not a fault of our
own documentation ;-).

Perhaps something like this would clarify the description?

 Documentation/git-send-email.adoc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git c/Documentation/git-send-email.adoc w/Documentation/git-send-email.adoc
index 7f223db42d..53f30fccf9 100644
--- c/Documentation/git-send-email.adoc
+++ w/Documentation/git-send-email.adoc
@@ -267,8 +267,10 @@ must be used for each option.
 	Path to a store of trusted CA certificates for SMTP SSL/TLS
 	certificate validation (either a directory that has been processed
 	by 'c_rehash', or a single file containing one or more PEM format
-	certificates concatenated together: see verify(1) -CAfile and
-	-CApath for more information on these). Set it to an empty string
+	certificates concatenated together: see the description of the
+	`-CAfile` _<file>_ and the `-CApath` _<dir>_ options of OpenSSL's
+	`verify(1)` manual page for more information on these).
+	Set it to an empty string
 	to disable certificate verification. Defaults to the value of the
 	`sendemail.smtpSSLCertPath` configuration variable, if set, or the
 	backing SSL library's compiled-in default otherwise (which should



  reply	other threads:[~2025-05-30 17:16 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-13 18:28 [PATCH] docs: add instructions to use Yahoo with send-mail Aditya Garg
2025-05-13 18:33 ` Aditya Garg
2025-05-13 18:42   ` Junio C Hamano
2025-05-13 18:51     ` Aditya Garg
2025-05-13 19:36       ` Aditya Garg
2025-05-14 12:58 ` Junio C Hamano
2025-05-14 13:05   ` Aditya Garg
2025-05-15 10:29 ` [PATCH v2 0/2] docs: update email credential helpers Aditya Garg
2025-05-15 10:29   ` [PATCH v2 1/2] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-15 10:29   ` [PATCH v2 2/2] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-18  7:34   ` [PATCH v3 0/3] docs: update email credential helpers and improve formatting Aditya Garg
2025-05-18  7:35     ` [PATCH v3 1/3] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-18  7:36     ` [PATCH v3 2/3] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-18  7:36     ` [PATCH v3 3/3] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-19 12:51 ` [PATCH v4 0/3] docs: update email credential helpers and improve formatting Aditya Garg
2025-05-19 12:52   ` [PATCH v4 1/3] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-19 12:52   ` [PATCH v4 2/3] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-19 12:53   ` [PATCH v4 3/3] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-19 18:26   ` [PATCH v4 0/3] docs: update email credential helpers and improve formatting Junio C Hamano
2025-05-19 18:29     ` Aditya Garg
2025-05-28  7:05 ` [PATCH v5 0/4] " Aditya Garg
2025-05-28  7:05   ` [PATCH v5 1/4] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-28  7:05   ` [PATCH v5 2/4] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-29 18:15     ` Junio C Hamano
2025-05-29 19:04       ` Aditya Garg
2025-05-30 13:28         ` Junio C Hamano
2025-05-30 13:32           ` Aditya Garg
2025-05-30 17:15             ` Junio C Hamano [this message]
2025-05-30 17:19               ` Aditya Garg
2025-05-30 21:55                 ` Junio C Hamano
2025-05-30 14:48           ` Ben Knoble
2025-05-30 14:51             ` Aditya Garg
2025-05-28  7:05   ` [PATCH v5 3/4] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-28  7:05   ` [PATCH v5 4/4] docs: make the purpose of using app password for Gmail more clear in send-email Aditya Garg
2025-05-29 18:50     ` Junio C Hamano
2025-05-29 19:06       ` Aditya Garg
2025-05-28  7:23   ` [PATCH v5 0/4] docs: update email credential helpers and improve formatting Eric Sunshine
2025-05-28  9:36     ` Aditya Garg
2025-05-28  9:42       ` Aditya Garg
2025-05-28 10:05         ` Aditya Garg
2025-05-28 10:10       ` Aditya Garg
2025-05-30 11:37 ` [PATCH v6 " Aditya Garg
2025-05-30 11:37   ` [PATCH v6 1/4] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-30 11:37   ` [PATCH v6 2/4] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-30 11:37   ` [PATCH v6 3/4] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-30 11:37   ` [PATCH v6 4/4] docs: make the purpose of using app password for Gmail more clear in send-email Aditya Garg
2025-05-30 15:50 ` [PATCH v7 0/4] docs: add credential helper for yahoo and link Google's sendgmail tool Aditya Garg
2025-05-30 15:50   ` [PATCH v7 1/4] " Aditya Garg
2025-05-30 15:50   ` [PATCH v7 2/4] docs: improve formatting in git-send-email documentation Aditya Garg
2025-05-30 15:50   ` [PATCH v7 3/4] docs: remove credential helper links for emails from gitcredentials Aditya Garg
2025-05-30 15:50   ` [PATCH v7 4/4] docs: make the purpose of using app password for Gmail more clear in send-email Aditya Garg
2025-05-30 17:28     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbjraf29c.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=gargaditya08@live.com \
    --cc=git@vger.kernel.org \
    --cc=johannes.schindelin@gmx.de \
    --cc=julian@swagemakers.org \
    --cc=kristofferhaugsbakk@fastmail.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=sunshine@sunshineco.com \
    --cc=ziyao@disroot.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.