All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Martin Ågren" <martin.agren@gmail.com>
Cc: Christian Fredrik Johnsen via GitGitGadget
	<gitgitgadget@gmail.com>,
	git@vger.kernel.org,
	 Christian Fredrik Johnsen <christian@johnsen.no>
Subject: Re: [PATCH v2] refs: fix duplicated word in comment
Date: Wed, 09 Apr 2025 09:22:14 -0700	[thread overview]
Message-ID: <xmqqbjt5s3t5.fsf@gitster.g> (raw)
In-Reply-To: <CAN0heSoh4SuQcYHVVniO1BYH_C4O-BeF4kKxDg3uQPzpotLA1A@mail.gmail.com> ("Martin Ågren"'s message of "Mon, 7 Apr 2025 20:43:20 +0200")

Martin Ågren <martin.agren@gmail.com> writes:

> Ok. In general, there's some trade-off to be made between "make a small change
> at the top of a twenty-line comment and rewrap the whole thing causing more
> churn than necessary and create more room for conflicts with other topics" and
> "make the change and live with slightly less beautiful wrapping".

Nice to see this choice spelled out.

> In this
> particular case, the blast radius is small. `git show --word-diff` confirms
> that you simply removed the duplicate word and moved "common" (or "*").
>
> FWIW, this patch looks good to me.
>
> Martin

Thanks, both.
Will queue.

      reply	other threads:[~2025-04-09 16:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 18:39 [PATCH] refs: fix duplicated word in comment Christian Fredrik Johnsen via GitGitGadget
2025-04-05 10:01 ` Martin Ågren
2025-04-05 12:57 ` [PATCH v2] " Christian Fredrik Johnsen via GitGitGadget
2025-04-07 18:43   ` Martin Ågren
2025-04-09 16:22     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbjt5s3t5.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=christian@johnsen.no \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=martin.agren@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.