All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: rsbecker@nexbridge.com,  git@vger.kernel.org
Subject: Re: [PATCH v0 1/1] Teach git version --build-options about zlib+libcurl
Date: Wed, 26 Jun 2024 15:28:46 -0700	[thread overview]
Message-ID: <xmqqbk3nwd7l.fsf@gitster.g> (raw)
In-Reply-To: <20240626204232.GD441931@coredump.intra.peff.net> (Jeff King's message of "Wed, 26 Jun 2024 16:42:32 -0400")

Jeff King <peff@peff.net> writes:

> But that may just be me being overly conservative. If nobody looks at
> those symbols, I'm not sure what harm would come.

Yeah, perhaps on some exotic systems it may cause problems, but
until we see such a system, or we want to extend it to do the
curl_version() call for runtime, whichever comes earlier, I think
we can leave it as a (#leftoverbits) "future enhancement and
clean-up" task to be done after the dust settles.

Thanks.

  reply	other threads:[~2024-06-26 22:28 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-21 15:45 [PATCH v0 0/1] Teach git version --build-options about zlib+libcurl Randall S. Becker
2024-06-21 15:45 ` [PATCH v0 1/1] " Randall S. Becker
2024-06-21 18:20   ` Junio C Hamano
2024-06-21 18:28     ` Junio C Hamano
2024-06-21 18:33     ` rsbecker
2024-06-21 18:58       ` Junio C Hamano
2024-06-21 19:20         ` Junio C Hamano
2024-06-21 19:32           ` Randall Becker
2024-06-22  5:11           ` Junio C Hamano
2024-06-25 19:29             ` rsbecker
2024-06-25 20:58               ` Junio C Hamano
2024-06-25 22:02                 ` rsbecker
2024-06-26 20:42                 ` Jeff King
2024-06-26 22:28                   ` Junio C Hamano [this message]
2024-06-26 20:46               ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbk3nwd7l.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=rsbecker@nexbridge.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.