All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Britton Leo Kerin <britton.kerin@gmail.com>
Cc: Taylor Blau <me@ttaylorr.com>,  git@vger.kernel.org
Subject: Re: [PATCH v2 0/2] doc: bisect: change plural paths to singular pathspec
Date: Wed, 10 Jan 2024 14:38:16 -0800	[thread overview]
Message-ID: <xmqqbk9s95lz.fsf@gitster.g> (raw)
In-Reply-To: <ZZWWmXHa8ebtkZQ8@nand.local> (Taylor Blau's message of "Wed, 3 Jan 2024 12:17:13 -0500")

Taylor Blau <me@ttaylorr.com> writes:

> On Tue, Jan 02, 2024 at 07:02:05PM -0900, Britton Leo Kerin wrote:
>> Britton Leo Kerin (2):
>>   doc: use singular form of repeatable path arg
>>   doc: refer to pathspec instead of path
>>
>>  Documentation/git-bisect.txt | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> Range-diff against v1:
>> 1:  90c081dcab ! 1:  da40e4736b doc: use singular form of repeatable path arg
>>     @@ Commit message
>>          later document text mentions 'path' arguments, while it doesn't mention
>>          'paths'.
>>
>>     -    Signed-off-by: Britton L Kerin <britton.kergin@gmail.com>
>>     +    Signed-off-by: Britton Leo Kerin <britton.kergin@gmail.com>
>>
>>       ## Documentation/git-bisect.txt ##
>>      @@ Documentation/git-bisect.txt: The command takes various subcommands, and different options depending
>> -:  ---------- > 2:  d932b6d501 doc: refer to pathspec instead of path
>> --
>> 2.43.0
>
> Hmm. The end-state of these two patches looks good to me, but I probably
> would have written this change as a single change from "paths" ->
> "pathspec", not "paths" -> "path" -> "pathspec".

Have we seen a resolution to this comment?  I _think_ it is an OK
approach to take to do this in two steps, if the use of technical
term "pathspec" could be controversial, but since it is not, I am
fine with either one or two patches.  Since we already have the
two-patch version, let's take it.

Thanks.

  reply	other threads:[~2024-01-10 22:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-27 20:53 [PATCH 0/1] doc: git-bisect: change plural form to singular Britton Leo Kerin
2024-01-03  4:02 ` [PATCH v2 0/2] doc: bisect: change plural paths to singular pathspec Britton Leo Kerin
2024-01-03 17:17   ` Taylor Blau
2024-01-10 22:38     ` Junio C Hamano [this message]
     [not found] ` <20240103040207.661413-1-britton.kerin@gmail.com>
2024-01-03  4:02   ` [PATCH v2 1/2] doc: use singular form of repeatable path arg Britton Leo Kerin
2024-01-03  4:02   ` [PATCH v2 2/2] doc: refer to pathspec instead of path Britton Leo Kerin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbk9s95lz.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=britton.kerin@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.