From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Isoken Ibizugbe <isokenjune@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v2] builtin/branch.c: adjust error messages to coding guidelines
Date: Fri, 20 Oct 2023 10:10:01 -0700 [thread overview]
Message-ID: <xmqqbkctrziu.fsf@gitster.g> (raw)
In-Reply-To: <CAP8UFD1U0cz3CDdE_0d0FUgPKP2pX-ZcVDJqz2tW-+rnZ7rvQw@mail.gmail.com> (Christian Couder's message of "Fri, 20 Oct 2023 11:41:15 +0200")
Christian Couder <christian.couder@gmail.com> writes:
>> Hello Junio, I would appreciate your comment on this.
>
> Please don't expect Junio to give direct feedback on all the patches
> sent to the mailing list. This patch has already been reviewed by
> Rubén.
Correct.
> If Junio doesn't review it and if this patch is not mentioned
> in the next "What's cooking in git.git" email from Junio, it likely
> means that you should send a version 3 addressing Rubén's feedback
> about the commit message.
While the above may be a good advice, I try to be easier to read
than the above tealeaf-reading, especially to new contributors ;-)
At least I should comment on Rubén's comment, but I haven't got
around to it yet.
Thanks.
prev parent reply other threads:[~2023-10-20 17:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 5:12 [Outreachy][PATCH] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe
2023-10-18 18:19 ` Rubén Justo
2023-10-18 18:44 ` Junio C Hamano
2023-10-19 8:40 ` [PATCH v2] builtin/branch.c: " Isoken June Ibizugbe
2023-10-19 19:20 ` Rubén Justo
2023-10-20 17:31 ` Junio C Hamano
2023-10-20 17:59 ` Isoken Ibizugbe
2023-10-21 10:31 ` Rubén Justo
2023-10-21 10:27 ` Rubén Justo
2023-10-20 4:26 ` Isoken Ibizugbe
2023-10-20 9:41 ` Christian Couder
2023-10-20 17:10 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbkctrziu.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=isokenjune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.