From: Junio C Hamano <gitster@pobox.com>
To: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: ab/test-without-templates
Date: Mon, 27 Jun 2022 09:11:52 -0700 [thread overview]
Message-ID: <xmqqbkueqe5z.fsf@gitster.g> (raw)
In-Reply-To: <220627.864k06i8im.gmgdl@evledraar.gmail.com> ("Ævar Arnfjörð Bjarmason"'s message of "Mon, 27 Jun 2022 14:29:50 +0200")
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes:
> You may disagree with some or all of those, but this series doesn't try
> to get you to agree with any of them. It's just making our tests more
> sturdy and explicit in their intent by clearly declaring which parts of
> them are relying on our default templates.
>
> So it's helping us spot issues like the one fixed in 7f44842ac19
> (sparse-checkout: create leading directory, 2022-01-21) earlier.
It's like arguing "this series is a bugfix, so what it fixes are by
definition bugs", isn't it?
> I really don't disagree with you per-se about us defining some minimum
> viable template,...
Well then it becomes debatable if it is a "bug" not to handle
missing .git/info that needs "fixing" by this series, and it also
makes it debatable if 7f44842a (sparse-checkout: create leading
directory, 2022-01-21) was also a "bugfix", or just tightening
against environment the end-user broke, no?
next prev parent reply other threads:[~2022-06-27 16:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-22 19:32 What's cooking in git.git (Jun 2022, #07; Wed, 22) Junio C Hamano
2022-06-22 21:16 ` en/merge-tree (Was: Re: What's cooking in git.git (Jun 2022, #07; Wed, 22)) Elijah Newren
2022-06-22 23:13 ` en/merge-tree Junio C Hamano
2022-06-23 10:02 ` en/merge-tree (Was: Re: What's cooking in git.git (Jun 2022, #07; Wed, 22)) Johannes Schindelin
2022-06-23 10:55 ` ab/test-without-templates (was: " Ævar Arnfjörð Bjarmason
2022-06-23 22:12 ` ab/test-without-templates Junio C Hamano
2022-06-27 12:29 ` ab/test-without-templates Ævar Arnfjörð Bjarmason
2022-06-27 16:11 ` Junio C Hamano [this message]
2022-06-27 18:23 ` ab/test-without-templates Ævar Arnfjörð Bjarmason
2022-06-23 10:59 ` hx/unpack-streaming (was: What's cooking in git.git (Jun 2022, #07; Wed, 22)) Ævar Arnfjörð Bjarmason
2022-06-23 22:08 ` hx/unpack-streaming Junio C Hamano
2022-06-24 3:12 ` gc/submodule-update (was Re: What's cooking in git.git (Jun 2022, #07; Wed, 22)) Glen Choo
2022-06-24 15:35 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbkueqe5z.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.