From: Junio C Hamano <gitster@pobox.com>
To: "SZEDER Gábor" <szeder.dev@gmail.com>
Cc: "Jeff King" <peff@peff.net>, "Derrick Stolee" <stolee@gmail.com>,
"Carlo Marcelo Arenas Belón" <carenas@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] ci: add job for gcc-4.8 to GitHub Actions
Date: Tue, 17 Aug 2021 12:36:08 -0700 [thread overview]
Message-ID: <xmqqbl5v50ev.fsf@gitster.g> (raw)
In-Reply-To: <20210817111512.GA2257957@szeder.dev> ("SZEDER Gábor"'s message of "Tue, 17 Aug 2021 13:15:12 +0200")
SZEDER Gábor <szeder.dev@gmail.com> writes:
>> IMHO it may be more trouble than it's worth. If we can't find a compiler
>> that complains on this construct, then maybe it is not a construct worth
>> worrying too much about.
Absolutely. Of course, there are vendor compilers that are not GNU
or clang that may throw us surprises ;-)
> I for one like for loop initial declarations, because they allow us to
> limit the scope of the loop variable to the loop, and would love to
> see it used in more places (well, wherever possible, actually, but
> that'd be a lot of churn). So I would prefer to just drop this job
> sooner rather than later, update CodingGuidelines, and, if deemed
> necessary, launch a weather balloon.
I'd agree in general, but it must be done in a bit different order,
i.e. weather balloon first.
next prev parent reply other threads:[~2021-08-17 19:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 4:57 [PATCH] ci: add job for gcc-4.8 to GitHub Actions Carlo Marcelo Arenas Belón
2021-08-16 16:06 ` Derrick Stolee
2021-08-16 16:18 ` Jeff King
2021-08-17 11:15 ` SZEDER Gábor
2021-08-17 15:15 ` Jeff King
2021-08-17 19:36 ` Junio C Hamano [this message]
2021-08-16 16:58 ` Carlo Arenas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbl5v50ev.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.