From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Alvaro Aleman <aaleman@redhat.com>,
Git List <git@vger.kernel.org>,
Andreas Schwab <schwab@linux-m68k.org>
Subject: Re: [PATCH] ident: say whose identity is missing when giving user.name hint
Date: Fri, 21 Aug 2020 15:35:08 -0700 [thread overview]
Message-ID: <xmqqblj37hlv.fsf@gitster.c.googlers.com> (raw)
In-Reply-To: <CAPig+cSLxRVufZcnXa6JAbP-SYX486OebDS5hYjEhH7jaNgM5Q@mail.gmail.com> (Eric Sunshine's message of "Fri, 21 Aug 2020 17:37:58 -0400")
Eric Sunshine <sunshine@sunshineco.com> writes:
> On Fri, Aug 21, 2020 at 5:31 PM Alvaro Aleman <aaleman@redhat.com> wrote:
>> One nit though: There is no `--committer` flag for `git commit`,
>
> Indeed, that `--committer=` was a last-second edit (without checking
> docs).
Yeah, I forgot that we deliberately omit the command line option for
the committer info.
> How about this?
>
> If `user.name` and `user.email` have not been configured and the
> user invokes:
>
> git commit --author=...
>
> without specifying the committer, then Git errors out with a
> message asking the user to configure `user.name` and `user.email`
> but doesn't tell the user which attribution was missing. This can
> be confusing for a user new to Git who isn't aware of the
> distinction between user, author, and committer. Give such users
> a bit more help by extending the error message to also say which
> attribution is expected.
OK.
prev parent reply other threads:[~2020-08-21 22:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-21 16:15 --author arg on commit only works if there is an email configured already Alvaro Aleman
2020-08-21 18:28 ` Andreas Schwab
2020-08-21 18:46 ` Junio C Hamano
2020-08-21 19:55 ` Alvaro Aleman
2020-08-21 20:36 ` [PATCH] ident: say whose identity is missing when giving user.name hint Junio C Hamano
2020-08-21 20:52 ` Eric Sunshine
2020-08-21 21:13 ` Junio C Hamano
2020-08-21 21:31 ` Alvaro Aleman
2020-08-21 21:37 ` Eric Sunshine
2020-08-21 22:35 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqblj37hlv.fsf@gitster.c.googlers.com \
--to=gitster@pobox.com \
--cc=aaleman@redhat.com \
--cc=git@vger.kernel.org \
--cc=schwab@linux-m68k.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.