From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <christian.couder@gmail.com>
Cc: Simon Ruderich <simon@ruderich.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>,
Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
Subject: Re: Silly "git gc" UI issue.
Date: Mon, 23 Apr 2018 22:38:01 +0900 [thread overview]
Message-ID: <xmqqbmea9h6u.fsf@gitster-ct.c.googlers.com> (raw)
In-Reply-To: <CAP8UFD0_LvWkKSYd1MWrdoK-tqBcQqm32CUNrBqEfmjWdHkJgg@mail.gmail.com> (Christian Couder's message of "Sat, 21 Apr 2018 08:07:01 +0200")
Christian Couder <christian.couder@gmail.com> writes:
> On Sat, Apr 21, 2018 at 5:13 AM, Junio C Hamano <gitster@pobox.com> wrote:
>
>> @@ -388,6 +389,9 @@ int cmd_gc(int argc, const char **argv, const char *prefix)
>> if (argc > 0)
>> usage_with_options(builtin_gc_usage, builtin_gc_options);
>>
>> + if (prune_expire && parse_expiry_date(prune_expire, &dummy))
>> + die(_("Failed to parse prune expiry value %s"), prune_expire);
>
> Micronit: I thought we prefer error messages to start with a lower
> case letter, like:
>
> die(_("failed to parse prune expiry value %s"), prune_expire);
Thanks.
There is an existing "Failed..." already before the pre-context of
this hunk, which I'll fix with a preliminary clean-up patch.
next prev parent reply other threads:[~2018-04-23 13:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-19 1:45 Silly "git gc" UI issue Linus Torvalds
2018-04-19 1:52 ` Junio C Hamano
2018-04-19 1:55 ` Junio C Hamano
2018-04-19 2:16 ` Junio C Hamano
2018-04-19 2:29 ` Linus Torvalds
2018-04-19 3:22 ` Junio C Hamano
2018-04-19 5:10 ` Junio C Hamano
2018-04-20 7:27 ` Simon Ruderich
2018-04-21 3:13 ` Junio C Hamano
2018-04-21 6:07 ` Christian Couder
2018-04-23 13:38 ` Junio C Hamano [this message]
2018-04-19 2:19 ` Linus Torvalds
2018-04-19 10:34 ` Simon Ruderich
2018-04-20 0:14 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbmea9h6u.fsf@gitster-ct.c.googlers.com \
--to=gitster@pobox.com \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=simon@ruderich.org \
--cc=torvalds@linux-foundation.org \
--cc=ungureanupaulsebastian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.