From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
Jacob Keller <jacob.e.keller@intel.com>,
"git\@vger.kernel.org" <git@vger.kernel.org>,
Stefan Beller <stefanbeller@gmail.com>, Jeff King <peff@peff.net>,
Johannes Sixt <j6t@kdbg.org>
Subject: Re: [PATCH v7 6/7] submodule: refactor show_submodule_summary with helper function
Date: Thu, 18 Aug 2016 13:49:25 -0700 [thread overview]
Message-ID: <xmqqbn0p6bvu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+P7+xqQ-iaax3rtZbsGb6D4vBbwP7d63Qq4D2_z71V0Z4YCeg@mail.gmail.com> (Jacob Keller's message of "Thu, 18 Aug 2016 13:44:09 -0700")
Jacob Keller <jacob.keller@gmail.com> writes:
>>>> If we were to change those, we could discuss if we want to go with
>>>> full sentences
>>>> all the time:
>>>>
>>>> submodule is new
>>>> submodule is deleted
>>>> submodule is not initialized
>>>
>>> I agree, I'll make a new patch that does this as a cleanup prior to
>>> this re-work.
>> ...
> Sorry for being unclear myself, too. I'm keeping it as "not
> initialized" and updating the description of the patch that changed it
> from "not checked out" to "not initialized"
Whether it is done inside or outside the scope of this series, the
other two "is new"/"is deleted" updates look very sensible ones to
make in the longer run. I'd further suggest to unify "commits not
present" and "revision walker failed" into one error class. From
the end user's point of view, they aren't very different.
next prev parent reply other threads:[~2016-08-19 1:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 0:51 [PATCH v7 0/7] implement inline submodule diff format Jacob Keller
2016-08-18 0:51 ` [PATCH v7 1/7] diff.c: remove output_prefix_length field Jacob Keller
2016-08-18 0:51 ` [PATCH v7 2/7] graph: add support for --line-prefix on all graph-aware output Jacob Keller
2016-08-18 17:56 ` Stefan Beller
2016-08-18 18:26 ` Jacob Keller
2016-08-18 18:29 ` Jacob Keller
2016-08-18 0:51 ` [PATCH v7 3/7] diff: prepare for additional submodule formats Jacob Keller
2016-08-18 18:03 ` Stefan Beller
2016-08-18 0:51 ` [PATCH v7 4/7] submodule: allow do_submodule_path to work if given gitdir directly Jacob Keller
2016-08-18 18:06 ` Stefan Beller
2016-08-18 18:46 ` Junio C Hamano
2016-08-18 18:50 ` Jacob Keller
2016-08-18 0:51 ` [PATCH v7 5/7] submodule: correct output of submodule log format Jacob Keller
2016-08-18 18:25 ` Stefan Beller
2016-08-18 18:34 ` Jacob Keller
2016-08-18 0:51 ` [PATCH v7 6/7] submodule: refactor show_submodule_summary with helper function Jacob Keller
2016-08-18 7:00 ` David Aguilar
2016-08-18 7:37 ` Jacob Keller
2016-08-18 19:04 ` Stefan Beller
2016-08-18 20:24 ` Jacob Keller
2016-08-18 20:39 ` Stefan Beller
2016-08-18 20:44 ` Jacob Keller
2016-08-18 20:49 ` Junio C Hamano [this message]
2016-08-18 21:08 ` Jacob Keller
2016-08-18 0:51 ` [PATCH v7 7/7] diff: teach diff to display submodule difference with an inline diff Jacob Keller
2016-08-18 19:47 ` Stefan Beller
2016-08-18 20:13 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbn0p6bvu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
--cc=stefanbeller@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.