From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.keller@gmail.com>
Cc: Stefan Beller <sbeller@google.com>,
Git mailing list <git@vger.kernel.org>,
Jens Lehmann <Jens.Lehmann@web.de>
Subject: Re: weird diff output?
Date: Tue, 29 Mar 2016 17:04:54 -0700 [thread overview]
Message-ID: <xmqqbn5wvnix.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CA+P7+xoLZhKzHf6khQfT_pZ2=CQAp8Nmhc9B8+10+9=YYUZH3w@mail.gmail.com> (Jacob Keller's message of "Tue, 29 Mar 2016 16:05:57 -0700")
Jacob Keller <jacob.keller@gmail.com> writes:
> On Tue, Mar 29, 2016 at 11:16 AM, Stefan Beller <sbeller@google.com> wrote:
>> ...
>> To find a heuristic, which appeals both the C code
>> and the shell code, we could take the empty line
>> as a strong hint for the divider:
>
> This seems like a good heuristic. Can we think of any examples where
> it would produce wildly confusing diffs? I don't think it necessarily
> needs to be default but just a possible option when formatting diffs,
> much like we already have today.
I earlier said "50% of the time it is correct, you just do not
remember", but such an option with configuration variable would let
somebody interested set it permanently for his daily use of Git, and
it would help him to find out (1) if he sees a "Huh?" division less
(or more) often than he used to, and (2) if it gives a better
division for the same change to view the diff with the plain-vanilla
heuristic.
next prev parent reply other threads:[~2016-03-30 0:05 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 0:26 weird diff output? Jacob Keller
2016-03-29 17:37 ` Stefan Beller
2016-03-29 17:54 ` Junio C Hamano
2016-03-29 18:16 ` Stefan Beller
2016-03-29 23:05 ` Jacob Keller
2016-03-30 0:04 ` Junio C Hamano [this message]
2016-03-30 4:55 ` Jeff King
2016-03-30 6:05 ` Stefan Beller
2016-03-30 6:05 ` Jacob Keller
2016-03-30 19:14 ` Jacob Keller
2016-03-30 19:31 ` Jacob Keller
2016-03-30 19:40 ` Stefan Beller
2016-04-01 19:04 ` Junio C Hamano
2016-03-31 13:47 ` Jeff King
2016-04-06 17:47 ` Jacob Keller
2016-04-12 19:34 ` Stefan Beller
2016-04-14 13:56 ` Davide Libenzi
2016-04-14 18:34 ` Jeff King
2016-04-14 21:05 ` Stefan Beller
2016-04-15 0:07 ` [RFC PATCH, WAS: "weird diff output?"] Implement better chunk heuristics Stefan Beller
2016-04-15 0:26 ` Jacob Keller
2016-04-15 0:43 ` Stefan Beller
2016-04-15 2:07 ` Jacob Keller
2016-04-15 2:09 ` Junio C Hamano
2016-04-15 3:33 ` Stefan Beller
2016-04-15 0:21 ` weird diff output? Jacob Keller
2016-04-15 2:18 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbn5wvnix.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=jacob.keller@gmail.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.