From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Jacob Keller <jacob.e.keller@intel.com>,
Michael J Gruber <git@drmicha.warpmail.net>,
git@vger.kernel.org, Mark Strapetz <marc.strapetz@syntevo.com>,
Stefan Beller <sbeller@google.com>,
Jacob Keller <jacob.keller@gmail.com>
Subject: Re: [PATCH v3 1/2] t/lib-http/apache.conf: load mod_unixd module in apache 2.4
Date: Thu, 25 Feb 2016 15:16:55 -0800 [thread overview]
Message-ID: <xmqqbn74mlco.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20160225220045.GA10267@sigill.intra.peff.net> (Jeff King's message of "Thu, 25 Feb 2016 17:00:45 -0500")
Jeff King <peff@peff.net> writes:
> On Thu, Feb 25, 2016 at 10:57:11AM -0800, Jacob Keller wrote:
>
>> From: Jacob Keller <jacob.keller@gmail.com>
>>
>> Since 2.4, apache will fail to load unless mod_unixd is loaded in order
>> to drop privileges.
>>
>> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
>> ---
>>
>> I am not sure why this wasn't there already, but I am unable to run
>> httpd 2.4.18 without it, on Fedora 23.
>>
>> t/lib-httpd/apache.conf | 3 +++
>> 1 file changed, 3 insertions(+)
>
> Michael (cc'd) posted an identical patch with some more discussion back
> in May:
>
> http://article.gmane.org/gmane.comp.version-control.git/268770
>
> The series languished because none of the reviewers had systems that
> reproduced the problem, and I think there's some additional work needed
> to get all of the svn-over-http tests running[1].
>
> I think this bit should be OK to take without the rest (though I like
> the extra discussion in the original).
I can resurrect 745a5487 (t/lib-httpd: load mod_unixd, 2015-04-08),
which is still on 'pu', and apply 2/2 from Jacov on top of it.
Thanks.
>
> -Peff
>
> [1] http://article.gmane.org/gmane.comp.version-control.git/284349
next prev parent reply other threads:[~2016-02-25 23:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-25 18:57 [PATCH v3 1/2] t/lib-http/apache.conf: load mod_unixd module in apache 2.4 Jacob Keller
2016-02-25 18:57 ` [PATCH v3 2/2] git: submodule honor -c credential.* from command line Jacob Keller
2016-02-26 1:55 ` Eric Sunshine
2016-02-26 2:19 ` Jacob Keller
2016-02-26 2:26 ` Eric Sunshine
2016-02-26 2:31 ` Jacob Keller
2016-02-26 6:07 ` Jeff King
2016-02-26 7:32 ` Jacob Keller
2016-02-25 22:00 ` [PATCH v3 1/2] t/lib-http/apache.conf: load mod_unixd module in apache 2.4 Jeff King
2016-02-25 23:16 ` Junio C Hamano [this message]
2016-02-25 23:17 ` Junio C Hamano
2016-02-25 23:18 ` Junio C Hamano
2016-02-25 23:39 ` Jacob Keller
2016-02-25 23:41 ` Junio C Hamano
2016-02-25 23:43 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbn74mlco.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@drmicha.warpmail.net \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=marc.strapetz@syntevo.com \
--cc=peff@peff.net \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.