All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "erik elfström" <erik.elfstrom@gmail.com>
Cc: Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t7300: fix broken && chains
Date: Tue, 01 Sep 2015 09:23:51 -0700	[thread overview]
Message-ID: <xmqqbndmt8fc.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <CAMpP7NZMMYyCbmnzhLTqa73TD_mqk+rO8=D0v9qb0z_UmBQ-rg@mail.gmail.com> ("erik elfström"'s message of "Tue, 1 Sep 2015 08:31:37 +0200")

erik elfström <erik.elfstrom@gmail.com> writes:

> On Mon, Aug 31, 2015 at 6:58 PM, Junio C Hamano <gitster@pobox.com> wrote:
>>
>> ...  It may have been
>> better if you didn't do "while we are here" and corrected only the
>> &&-chain in patch 1/2 and then updated the style of the tests to
>> take advantage of the newer facilities recent test-lib has in a
>> separate patch 2/2, but this will do at least for now.
>>
>> Will queue.
>>
>> Thanks.
>
> I can do a re-roll with the chain fix in the first patch and a more
> thorough modernization of t7300 in separate patches if you'd like? I
> almost went this way for v1 but decided to limit the scope for the
> first version.

I'd say it is too much work for something that we already have
reviewed and queued ;-) Let's have this patch as-is.

Modernization and clean-up from time to time is a good thing to do,
but we only have limited review bandwidth, so let's not overdo it.

Thanks.

  reply	other threads:[~2015-09-01 16:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-30  9:18 [PATCH] t7300: fix broken && chains Erik Elfström
2015-08-31 16:58 ` Junio C Hamano
2015-09-01  6:31   ` erik elfström
2015-09-01 16:23     ` Junio C Hamano [this message]
2015-08-31 18:54 ` Jeff King
2015-09-01  6:27   ` erik elfström
2015-09-01 17:36     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbndmt8fc.fsf@gitster.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=erik.elfstrom@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.