From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
"Git Mailing List" <git@vger.kernel.org>
Subject: Re: [PATCH] parse_color: fix return value for numeric color values 0-8
Date: Tue, 20 Jan 2015 16:36:05 -0800 [thread overview]
Message-ID: <xmqqbnltynpm.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150121000352.GA12543@peff.net> (Jeff King's message of "Tue, 20 Jan 2015 19:03:52 -0500")
Jeff King <peff@peff.net> writes:
>> Thanks; somebody should have caught this before we applied and
>> merged to 'master', but the process obviously did not work well.
>
> I am not too surprised. The use of numeric values for colors was
> completely undocumented, and we did not have any test coverage for it. I
> did not even know it existed until I started refactoring the function,
> and wondered what was going on (though I did try to preserve it once I
> found it).
I was specifically thinking about the failure of "eyeball test".
I often do "git am" followed by "git show -U20" to check the change
in context, which _should_ have caught the lack of return there.
prev parent reply other threads:[~2015-01-21 0:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 23:57 [ANNOUNCE] Git v2.3.0-rc0 Junio C Hamano
2015-01-14 13:11 ` Christian Neukirchen
2015-01-20 21:49 ` Ævar Arnfjörð Bjarmason
2015-01-20 22:14 ` [PATCH] parse_color: fix return value for numeric color values 0-8 Jeff King
2015-01-20 23:57 ` Junio C Hamano
2015-01-21 0:03 ` Jeff King
2015-01-21 0:36 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbnltynpm.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.