From: Junio C Hamano <gitster@pobox.com>
To: Stefan Beller <sbeller@google.com>
Cc: git@vger.kernel.org, mhagger@alum.mit.edu, jrnieder@gmail.com,
ronniesahlberg@gmail.com, Ronnie Sahlberg <sahlberg@google.com>
Subject: Re: [PATCH 2/8] refs.c: rename the transaction functions
Date: Thu, 11 Dec 2014 13:42:23 -0800 [thread overview]
Message-ID: <xmqqbnn9eudc.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1417833995-25687-3-git-send-email-sbeller@google.com> (Stefan Beller's message of "Fri, 5 Dec 2014 18:46:29 -0800")
Stefan Beller <sbeller@google.com> writes:
> Rename the transaction functions. Remove the leading ref_ from the
> names and append _ref to the names for functions that create/delete/
> update sha1 refs.
>
> The goal in the long term is to have different things running through
> the transaction api, such as the .git/config file.
>
> The dream is to...
I was trying to polish somebody else's topic that does not have
anythning to do with refs/reflogs/transactions today, and had to
suffer from conflicts from the textual difference between
transaction_begin and ref_transaction_begin, which I feel is totally
unnecessary at this moment.
I'd really prefer to see this done long after all the dust from
"ref" changes from various people have settled, especially given
that we are not doing anything for that "dream" right now.
Thanks.
next prev parent reply other threads:[~2014-12-11 21:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-06 2:46 [PATCH 0/8] Making reflog modifications part of the transactions API Stefan Beller
2014-12-06 2:46 ` [PATCH 1/8] refs.c: let fprintf handle the formatting Stefan Beller
2014-12-06 2:46 ` [PATCH 2/8] refs.c: rename the transaction functions Stefan Beller
2014-12-11 21:42 ` Junio C Hamano [this message]
2014-12-11 21:48 ` Stefan Beller
2014-12-06 2:46 ` [PATCH 3/8] refs.c: rename transaction.updates to transaction.ref_updates Stefan Beller
2014-12-06 2:46 ` [PATCH 4/8] refs.c: add transaction function to append to the reflog Stefan Beller
2014-12-11 21:50 ` Junio C Hamano
2014-12-06 2:46 ` [PATCH 5/8] refs.c: add transaction function to delete " Stefan Beller
2014-12-06 2:46 ` [PATCH 6/8] refs.c: use a reflog transaction when writing during expire Stefan Beller
2014-12-06 2:46 ` [PATCH 7/8] refs.c: rename log_ref_setup to create_reflog Stefan Beller
2014-12-06 2:46 ` [PATCH 8/8] refs.c: allow deleting refs with a broken sha1 Stefan Beller
2014-12-08 20:05 ` [PATCH 0/8] Making reflog modifications part of the transactions API Stefan Beller
2014-12-08 21:54 ` Jonathan Nieder
2014-12-12 16:17 ` Michael Haggerty
2014-12-12 20:51 ` Stefan Beller
2014-12-12 21:16 ` ronnie sahlberg
2014-12-14 23:17 ` Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbnn9eudc.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=mhagger@alum.mit.edu \
--cc=ronniesahlberg@gmail.com \
--cc=sahlberg@google.com \
--cc=sbeller@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.