All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: David Turner <dturner@twopensource.com>,
	Git List <git@vger.kernel.org>,
	David Turner <dturner@twitter.com>
Subject: Re: [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit
Date: Sun, 13 Jul 2014 10:22:34 -0700	[thread overview]
Message-ID: <xmqqbnst18dh.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAPig+cQpzomDmwVqgDGrP4qC1OujRXu5e1wc=EwX61k_RpLbKg@mail.gmail.com> (Eric Sunshine's message of "Fri, 11 Jul 2014 19:56:35 -0400")

Eric Sunshine <sunshine@sunshineco.com> writes:

>> +       (echo p; echo 1; echo; echo s; echo n; echo y; echo q) | git commit --interactive -m foo
>
> Broken &&-chain.
>
> Would a printf make this more readable?
>
>     printf "p\n1\n\ns\nn\ny\nq\n" | git commt ... &&
>
> Perhaps not.

But

	printf "%s\n" p 1 "" s n y q

is vastly more readable, I would think.

Don't we have test_write_lines which is exactly that, though?

  reply	other threads:[~2014-07-13 17:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-11 23:22 [PATCH v7 1/4] cache-tree: Create/update cache-tree on checkout David Turner
2014-07-11 23:22 ` [PATCH v7 2/4] test-dump-cache-tree: invalid trees are not errors David Turner
2014-07-11 23:22 ` [PATCH v7 3/4] cache-tree: subdirectory tests David Turner
2014-07-11 23:22 ` [PATCH v7 4/4] cache-tree: Write updated cache-tree after commit David Turner
2014-07-11 23:56   ` Eric Sunshine
2014-07-13 17:22     ` Junio C Hamano [this message]
2014-07-13 18:58       ` Eric Sunshine

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqbnst18dh.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=dturner@twitter.com \
    --cc=dturner@twopensource.com \
    --cc=git@vger.kernel.org \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.