From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] symbolic-ref: trivial style fix
Date: Tue, 15 Oct 2013 16:34:37 -0700 [thread overview]
Message-ID: <xmqqbo2q9khe.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20131015231628.GG9464@google.com> (Jonathan Nieder's message of "Tue, 15 Oct 2013 16:16:28 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
>> - && dfa->nodes[node].type == CHARACTER
>> + && dfa->nodes[node].type == CHARACTER
>
> It took a little staring to see what changed here. The preimage has
> a tab, probably from an autoformatter gone wild. I don't think fixing
> it should interfere with importing new versions of compat/regex, so
> the change seems fine.
xdiff/xemit.c had the breakage of the same nature. Perhaps the
commit log message should mention these two.
next prev parent reply other threads:[~2013-10-15 23:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-21 16:29 [PATCH] symbolic-ref: trivial style fix Felipe Contreras
2013-10-15 22:16 ` Junio C Hamano
2013-10-15 23:16 ` Jonathan Nieder
2013-10-15 23:34 ` Junio C Hamano [this message]
2013-10-16 3:33 ` Felipe Contreras
2013-10-16 21:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqbo2q9khe.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.