From: Junio C Hamano <gitster@pobox.com>
To: Tian Yuchen <cat@malon.dev>
Cc: git@vger.kernel.org, christian.couder@gmail.com, ps@pks.im,
Ayush Chandekar <ayu.chandekar@gmail.com>,
Olamide Caleb Bello <belkid98@gmail.com>
Subject: Re: [PATCH v1 3/4] environment: move 'trust_executable_bit' into repo_config_values
Date: Tue, 09 Jun 2026 06:45:46 -0700 [thread overview]
Message-ID: <xmqqcxxzsu7p.fsf@gitster.g> (raw)
In-Reply-To: <8083b217-4a56-48ee-b34d-b4596d45e382@malon.dev> (Tian Yuchen's message of "Tue, 2 Jun 2026 02:03:15 +0800")
Tian Yuchen <cat@malon.dev> writes:
> On 6/1/26 18:10, Tian Yuchen wrote:
>
>> That’s true: I had actually planned to start migrating has_symlinks as
>> soon as this series was approved. Since you think it would be better to
>> merge them into a single series, I’ll go ahead and do that ;)
>>
>
> I’ve found that migrating has_symlinks seems to be quite a tricky
> business. Some callers in certain files pass very few parameters, and
> the call stack is quite deep, if I am correct. so I feel that adding a
> repo for this purpose might be overkill. Perhaps it would be better to
> focus on trust_executable_bit for now?
>
> Regards, yuchen
Sounds fine. Thanks for digging.
next prev parent reply other threads:[~2026-06-09 13:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-30 16:05 [PATCH v1 0/4] environment.c: migrate 'trust_executable_bit' into 'repo_config_values' Tian Yuchen
2026-05-30 16:05 ` [PATCH v1 1/4] read-cache: remove redundant extern declarations Tian Yuchen
2026-05-30 16:05 ` [PATCH v1 2/4] read-cache: move 'ce_mode_from_stat()' to 'read-cache.c' Tian Yuchen
2026-06-04 6:47 ` Patrick Steinhardt
2026-05-30 16:05 ` [PATCH v1 3/4] environment: move 'trust_executable_bit' into repo_config_values Tian Yuchen
2026-05-30 18:02 ` Christian Couder
2026-05-30 23:17 ` Junio C Hamano
2026-06-01 10:10 ` Tian Yuchen
2026-06-01 18:03 ` Tian Yuchen
2026-06-09 13:45 ` Junio C Hamano [this message]
2026-05-30 16:05 ` [PATCH v1 4/4] read-cache: pass 'istate' to stat/mode helper functions Tian Yuchen
2026-05-30 18:14 ` Christian Couder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcxxzsu7p.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=ayu.chandekar@gmail.com \
--cc=belkid98@gmail.com \
--cc=cat@malon.dev \
--cc=christian.couder@gmail.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.