From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: <git@vger.kernel.org>, Jeff King <peff@peff.net>
Subject: Re: [PATCH] rev-parse: have --parseopt callers exit 0 on --help
Date: Mon, 16 Mar 2026 17:47:19 -0700 [thread overview]
Message-ID: <xmqqcy13mgdk.fsf@gitster.g> (raw)
In-Reply-To: <20260316220742.1286157-1-sandals@crustytoothpaste.net> (brian m. carlson's message of "Mon, 16 Mar 2026 22:07:42 +0000")
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
> Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
> ---
> parse-options.c | 2 +-
> t/t1502-rev-parse-parseopt.sh | 9 +++++++--
> t/t1502/optionspec-neg.help | 1 +
> t/t1502/optionspec.help | 1 +
> 4 files changed, 10 insertions(+), 3 deletions(-)
Has t1517 passed for you?
Queued directly on top of v2.53.0, I am seeing:
>>>>>
expecting success of 1517.169 ''git instaweb -h' outside a repository':
test_expect_code 129 nongit git $cmd -h >usage &&
test_grep "[Uu]sage: git $cmd " usage
test_expect_code: command exited with 0, we wanted 129 nongit git instaweb -h
not ok 169 - 'git instaweb -h' outside a repository
<<<<<
next prev parent reply other threads:[~2026-03-17 0:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-15 0:52 Unexpected exit code for --help with rev-parse --parseopt brian m. carlson
2026-03-15 3:14 ` Jeff King
2026-03-15 16:59 ` brian m. carlson
2026-03-15 18:16 ` Jeff King
2026-03-16 22:07 ` [PATCH] rev-parse: have --parseopt callers exit 0 on --help brian m. carlson
2026-03-17 0:47 ` Junio C Hamano [this message]
2026-03-17 11:59 ` brian m. carlson
2026-03-17 14:55 ` Jeff King
2026-03-17 15:07 ` Jeff King
2026-03-17 17:06 ` Junio C Hamano
2026-03-17 18:44 ` Jeff King
2026-03-18 0:24 ` brian m. carlson
2026-03-18 1:22 ` Jeff King
2026-03-18 2:45 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcy13mgdk.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.