All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Mirko Faina <mroik@delayed.space>,  git@vger.kernel.org
Subject: Re: [PATCH v3] apply.c: fix -p argument parsing
Date: Thu, 12 Mar 2026 21:19:47 -0700	[thread overview]
Message-ID: <xmqqcy189x98.fsf@gitster.g> (raw)
In-Reply-To: <20260313001629.GA3193660@coredump.intra.peff.net> (Jeff King's message of "Thu, 12 Mar 2026 20:16:29 -0400")

Jeff King <peff@peff.net> writes:

>> diff --git a/t/t4120/patch b/t/t4120/patch
>
> Not related to the failure, but IMHO we should keep small data like this
> in the script itself, rather than as auxiliary files. The t/ directory
> is already quite crowded, and it is often easier to refer to it when
> it's near the tests themselves.

A very good suggestion.  I actually did find it a bit annoying to
see an extra file there, but somehow failed to mention it in my
review.  Creating one in a set-up step and reusing it would be just
as simple as shipping an extra file.

Thanks.

  parent reply	other threads:[~2026-03-13  4:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 23:26 [PATCH] apply.c: fix -p argument parsing Mirko Faina
2026-03-09 23:43 ` Junio C Hamano
2026-03-10  0:54 ` [PATCH v2] " Mirko Faina
2026-03-10  3:31   ` Junio C Hamano
2026-03-10  4:45     ` Mirko Faina
2026-03-10  5:06   ` [PATCH v3] " Mirko Faina
2026-03-10 13:13     ` Junio C Hamano
2026-03-13  0:16     ` Jeff King
2026-03-13  1:12       ` Jeff King
2026-03-13  1:29         ` Jeff King
2026-03-13  4:27         ` Junio C Hamano
2026-03-13  4:19       ` Junio C Hamano [this message]
2026-03-13  3:19     ` [PATCH v4] " Mirko Faina
2026-03-13  4:39       ` Junio C Hamano
2026-03-16  0:51       ` [PATCH] " Mirko Faina
2026-03-16  0:52         ` Mirko Faina
2026-03-16 19:56         ` Junio C Hamano
2026-03-15 17:22 ` Tian Yuchen
2026-03-15 17:56   ` Mirko Faina

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcy189x98.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=mroik@delayed.space \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.