All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Michael Lohmann <git@lohmann.sh>,  git@vger.kernel.org
Subject: Re: [PATCH v3] builtin/reflog: respect user config in "write" subcommand
Date: Wed, 01 Oct 2025 09:50:48 -0700	[thread overview]
Message-ID: <xmqqcy7636s7.fsf@gitster.g> (raw)
In-Reply-To: <aNzaKAuuzzX1xg6I@pks.im> (Patrick Steinhardt's message of "Wed, 1 Oct 2025 09:37:12 +0200")

Patrick Steinhardt <ps@pks.im> writes:

> On Tue, Sep 30, 2025 at 09:53:20PM +0200, Michael Lohmann wrote:
>> The reflog write recognizes only GIT_COMMITTER_NAME and
>> GIT_COMMITTER_EMAIL environment variables, but forgot to honor the
>> user.name and user.email configuration variables, due to lack of
>> repo_config() call to grab these values from the configuration files.
>> 
>> The test suite sets these variables, so this behavior was unnoticed.
>> 
>> Ensure that the reflog write also uses the values of user.name and
>> user.email if set in the Git configuration.
>> 
>> Co-authored-by: Patrick Steinhardt <ps@pks.im>
>> Signed-off-by: Michael Lohmann <git@lohmann.sh>
>
> Thanks, this version looks good to me!

Yup.  Will apply on top of the ps/reflog-migrate-fixes topic.

I didn't realize "reflog write" was so new ;-)

Thanks.

      reply	other threads:[~2025-10-01 16:50 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-29 11:11 git reflog write does not pick up user.name and user.email from config Michael
2025-09-29 23:57 ` Patrick Steinhardt
2025-09-30  9:14   ` [PATCH] builtin/reflog: respect user config in "write" subcommand gitmlko
2025-09-30 11:26     ` Patrick Steinhardt
2025-09-30 14:37       ` [PATCH v2] " git
2025-09-30 17:13         ` Junio C Hamano
2025-09-30 19:53           ` [PATCH v3] " Michael Lohmann
2025-10-01  7:37             ` Patrick Steinhardt
2025-10-01 16:50               ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcy7636s7.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@lohmann.sh \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.