From: Junio C Hamano <gitster@pobox.com>
To: Philippe Blain <levraiphilippeblain@gmail.com>
Cc: Git mailing list <git@vger.kernel.org>, Taylor Blau <me@ttaylorr.com>
Subject: Re: Test failure in p5332-multi-pack-reuse.sh
Date: Mon, 21 Apr 2025 21:06:12 -0700 [thread overview]
Message-ID: <xmqqcyd46dsb.fsf@gitster.g> (raw)
In-Reply-To: <292ae7a3-2aad-1f22-2afe-739ec921d6b7@gmail.com> (Philippe Blain's message of "Mon, 21 Apr 2025 22:01:25 -0400")
Philippe Blain <levraiphilippeblain@gmail.com> writes:
> Sidenote: on GitHub CI, I could not demonstrate the failure on Linux
> because all Linux jobs run in containers, and the images we use do
> not have Git installed, such that actions/checkout@v4 uses the GitHub
> API to download the repository instead of cloning it [3]. This leads
> die_if_build_dir_not_repo from perf-lib.sh to fail with
> "No $GIT_PERF_REPO defined, and your build directory is not a repo" [4].
> We could fix that by installing the 'git' package before the 'actions/checkout'
> step, but we would need to account for the different package managers of
> the distros we test on.
Not limited to this topic, but wouldn't it make more sense to first
run install-dependencies (including "/usr/bin/git") and then invoke
the actions/checkout thing, I have to wonder. We were bitten by a
separate topic due to the same issue quite recently.
Thanks.
next prev parent reply other threads:[~2025-04-22 4:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-22 2:01 Test failure in p5332-multi-pack-reuse.sh Philippe Blain
2025-04-22 4:06 ` Junio C Hamano [this message]
2025-04-22 11:16 ` [PATCH] p5332: drop "+" from --stdin-packs input Jeff King
2025-04-22 15:49 ` Junio C Hamano
2025-05-01 16:03 ` Jeff King
2025-04-22 17:24 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyd46dsb.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=levraiphilippeblain@gmail.com \
--cc=me@ttaylorr.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.