From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org, Shubham Kanodia <shubham.kanodia10@gmail.com>
Subject: Re: [PATCH v3] builtin/gc: fix crash when running `git maintenance start`
Date: Thu, 10 Oct 2024 10:09:39 -0700 [thread overview]
Message-ID: <xmqqcyk7lwa4.fsf@gitster.g> (raw)
In-Reply-To: <a5b1433abfd84cb627efc17f52e0d644ee207bb0.1728538282.git.ps@pks.im> (Patrick Steinhardt's message of "Thu, 10 Oct 2024 07:33:01 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> + write_script script/systemctl <<-\EOF &&
> + echo "$*" >>../systemctl.log
> + EOF
Ah, for the purpose of this test, we _know_ in which directory the
"systemctl" will be spawned, so this is good enough for us, of
course.
> + git init repo &&
> + (
> + cd repo &&
> + sane_unset GIT_TEST_MAINT_SCHEDULER &&
> + PATH="$PWD/../script:$PATH" git maintenance start --scheduler=systemd
I suspect we can use the same idea and add a relative path in $PATH
for the test, perhaps, even though it is not a good coding
discipline. If $PWD, instead of $(pwd), works, it is perfectly OK.
Will queue. Thanks.
next prev parent reply other threads:[~2024-10-10 17:09 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-08 10:50 Bug: `git maintenance start` is likely broken in 2.47 Shubham Kanodia
2024-10-08 11:45 ` Patrick Steinhardt
2024-10-08 12:15 ` [PATCH] builtin/gc: fix crash when running `git maintenance start` Patrick Steinhardt
2024-10-08 18:30 ` Derrick Stolee
2024-10-09 2:58 ` Derrick Stolee
2024-10-09 6:28 ` Patrick Steinhardt
2024-10-08 18:33 ` Junio C Hamano
2024-10-09 23:14 ` Junio C Hamano
2024-10-10 4:54 ` Patrick Steinhardt
2024-10-10 5:10 ` Patrick Steinhardt
2024-10-09 7:08 ` [PATCH v2] " Patrick Steinhardt
2024-10-09 13:13 ` Derrick Stolee
2024-10-09 17:28 ` Junio C Hamano
2024-10-09 17:10 ` Junio C Hamano
2024-10-10 5:33 ` [PATCH v3] " Patrick Steinhardt
2024-10-10 17:09 ` Junio C Hamano [this message]
2024-10-14 4:44 ` Shubham Kanodia
2024-10-14 8:38 ` Patrick Steinhardt
2024-10-15 0:36 ` Taylor Blau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyk7lwa4.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
--cc=shubham.kanodia10@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.