From: Junio C Hamano <gitster@pobox.com>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git List <git@vger.kernel.org>, Patrick Steinhardt <ps@pks.im>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
Eric Sunshine <sunshine@sunshineco.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH v2 2/1] t-strvec: improve check_strvec() output
Date: Mon, 15 Jul 2024 07:44:03 -0700 [thread overview]
Message-ID: <xmqqcyne90lo.fsf@gitster.g> (raw)
In-Reply-To: <f2bcee2b-88fa-4dcd-8247-f68d842c6a4c@web.de> ("René Scharfe"'s message of "Sun, 14 Jul 2024 19:06:50 +0200")
René Scharfe <l.s.r@web.de> writes:
> The macro check_strvec calls the function check_strvec_loc(), which
> performs the actual checks. They report the line number inside that
> function on error, which is not very helpful. Before the previous
> patch half of them triggered an assertion that reported the caller's
> line number using a custom message, which was more useful, but a bit
> awkward.
> ...
> We can let check_strvec add the terminating NULL for us and remove it
> from callers, making it impossible to forget. Leave that conversion for
> a future patch, though, since this reimplementation is already intrusive
> enough.
>
> Reported-by: Jeff King <peff@peff.net>
> Signed-off-by: René Scharfe <l.s.r@web.de>
> ---
> For next, on top of c6f35e529e t-strvec: use test_msg().
Thanks.
next prev parent reply other threads:[~2024-07-15 14:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 18:04 [PATCH] t-strvec: use test_msg() René Scharfe
2024-07-04 18:31 ` Eric Sunshine
2024-07-05 9:44 ` Phillip Wood
2024-07-05 17:03 ` [PATCH v2] " René Scharfe
2024-07-09 11:32 ` Jeff King
2024-07-14 10:17 ` René Scharfe
2024-07-16 1:43 ` Jeff King
2024-07-16 16:43 ` René Scharfe
2024-07-14 17:06 ` [PATCH v2 2/1] t-strvec: improve check_strvec() output René Scharfe
2024-07-15 14:44 ` Junio C Hamano [this message]
2024-07-14 17:06 ` [PATCH v2 3/1] t-strvec: tighten .alloc check in check_strvec René Scharfe
2024-07-15 14:43 ` Junio C Hamano
2024-07-15 16:47 ` René Scharfe
2024-07-15 17:27 ` Junio C Hamano
2024-07-14 10:17 ` [PATCH v3] t-strvec: improve check_strvec() output René Scharfe
2024-07-14 17:06 ` René Scharfe
2024-07-16 4:37 ` Jeff King
2024-07-16 15:20 ` Junio C Hamano
2024-07-16 16:14 ` [PATCH] t-strvec: fix type mismatch in check_strvec René Scharfe
2024-07-16 16:33 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyne90lo.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=l.s.r@web.de \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=ps@pks.im \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.