From: Junio C Hamano <gitster@pobox.com>
To: Pi Fisher <pi.l.d.fisher@gmail.com>
Cc: git@vger.kernel.org, glencbz@gmail.com
Subject: Re: [PATCH] typo: Replace 'commitish' with 'committish'
Date: Wed, 10 Apr 2024 14:15:38 -0700 [thread overview]
Message-ID: <xmqqcyqwsyv9.fsf@gitster.g> (raw)
In-Reply-To: <20240407212111.55362-1-Pi.L.D.Fisher@gmail.com> (Pi Fisher's message of "Sun, 7 Apr 2024 17:21:08 -0400")
Pi Fisher <pi.l.d.fisher@gmail.com> writes:
> Across only three files, comments and a single function name used
> 'commitish' rather than 'commit-ish' or 'committish' as the spelling.
> The git glossary accepts a hyphen or a double-t, but not a single-t.
> Despite the typo in a translation file, none of the typos appear in
> user-visible locations.
>
> Signed-off-by: Pi Fisher <Pi.L.D.Fisher@gmail.com>
> ---
> The function name was renamed to use 'committish', preferring to avoid a
> hyphenated word. Comments referencing this function were rewritten to
> match the new name. In the translation file, 'commit-ish' appeared
> multiple times, but 'committish' appeared only once, so I changed the
> comment to match the more popular option.
Sounds good. Thanks.
prev parent reply other threads:[~2024-04-10 21:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-07 21:21 [PATCH] typo: Replace 'commitish' with 'committish' Pi Fisher
2024-04-10 21:15 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcyqwsyv9.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=glencbz@gmail.com \
--cc=pi.l.d.fisher@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.