All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: Kristoffer Haugsbakk <code@khaugsbakk.name>,
	 git@vger.kernel.org, Jonathan Nieder <jrnieder@gmail.com>,
	 Phillip Wood <phillip.wood123@gmail.com>
Subject: Re: [PATCH 2/2] sequencer: unset GIT_CHERRY_PICK_HELP for 'exec' commands
Date: Mon, 05 Feb 2024 19:54:49 -0800	[thread overview]
Message-ID: <xmqqcytal01i.fsf@gitster.g> (raw)
In-Reply-To: <b3ec5d0b-ac17-4d1e-a17d-d5adfbfc6ccf@oracle.com> (Vegard Nossum's message of "Tue, 6 Feb 2024 00:14:26 +0100")

Vegard Nossum <vegard.nossum@oracle.com> writes:

> On 06/02/2024 00:09, Junio C Hamano wrote:
>> "Kristoffer Haugsbakk" <code@khaugsbakk.name> writes:
>> 
>>> On Mon, Feb 5, 2024, at 15:13, Vegard Nossum wrote:
>>>> Link: https://lore.kernel.org/git/0adb1068-ef10-44ed-ad1d-e0927a09245d@gmail.com/
>>>> Suggested-by: Phillip Wood <phillip.wood123@gmail.com>
>>>> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
>>>
>>> `Link` is not really used a lot. Junio’s `refs/notes/amlog` will point
>>> back to the patch (which is often close to the “suggested by” and so
>>> on).
>> Good.  Also, is there [PATCH 1/2] that comes before this patch?
>
> Yes, kind of -- that's the testcase at the root of the thread:
>
> https://lore.kernel.org/git/20240202091850.160203-1-vegard.nossum@oracle.com/
>
> ("t/t3515-cherry-pick-rebase.sh: new testcase demonstrating broken
> behavior")

If the first one was NOT marked as [1/2], it is customary to call
such an "we thought just one patch was sufficient, but here is
another" step [2/1] instead, and that was why I was confused.

Perhaps it is a good idea to squash them together as a single bugfix
patch?

Thanks.

  reply	other threads:[~2024-02-06  3:54 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-02  9:18 [PATCH] t/t3515-cherry-pick-rebase.sh: new testcase demonstrating broken behavior Vegard Nossum
2024-02-04 11:14 ` Phillip Wood
2024-02-05 14:13   ` [PATCH 2/2] sequencer: unset GIT_CHERRY_PICK_HELP for 'exec' commands Vegard Nossum
2024-02-05 14:38     ` Kristoffer Haugsbakk
2024-02-05 23:09       ` Junio C Hamano
2024-02-05 23:14         ` Vegard Nossum
2024-02-06  3:54           ` Junio C Hamano [this message]
2024-02-07 14:03             ` Phillip Wood
2024-02-07 16:39               ` Junio C Hamano
2024-02-08  8:48                 ` Vegard Nossum
2024-02-08 14:26                   ` Phillip Wood
2024-02-08 17:20                     ` Junio C Hamano
2024-02-11 11:11                       ` Phillip Wood
2024-02-11 17:05                         ` Junio C Hamano
2024-02-15 14:24                           ` Vegard Nossum
2024-02-15 17:36                             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqcytal01i.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=code@khaugsbakk.name \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=phillip.wood123@gmail.com \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.