From: Junio C Hamano <gitster@pobox.com>
To: "Kilian Kilger via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Tao Klerks <tao@klerks.biz>,
Kilian Kilger <kkilger@gmail.com>
Subject: Re: [PATCH v2] git-p4: fix bug with encoding of p4 client name
Date: Mon, 18 Jul 2022 09:36:59 -0700 [thread overview]
Message-ID: <xmqqcze2s7h0.fsf@gitster.g> (raw)
In-Reply-To: <pull.1285.v2.git.git.1658134679233.gitgitgadget@gmail.com> (Kilian Kilger via GitGitGadget's message of "Mon, 18 Jul 2022 08:57:59 +0000")
"Kilian Kilger via GitGitGadget" <gitgitgadget@gmail.com> writes:
> From: Kilian Kilger <kkilger@gmail.com>
>
> The Perforce client name can contain arbitrary characters
> which do not decode to UTF-8. Use the fallback strategy
> implemented in metadata_stream_to_writable_bytes() also
> for the client name.
>
> Signed-off-by: Kilian Kilger <kkilger@gmail.com>
> ---
> git-p4: Fix bug with encoding of P4 client name
Sorry, is this to improve the topic that has already last Monday?
If so, it is way too late to update with a replacement patch, like
this. Instead, please send in a follow-up patch on top of what has
already been merged.
The description above seems to be identical to what was in the
previous round, but the patch seems to use a lot more code, so
such a follow-up patch would have plenty to explain how the new
strategy improves over the previous one.
Thanks.
next prev parent reply other threads:[~2022-07-18 16:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-08 8:01 [PATCH] git-p4: fix bug with encoding of p4 client name Kilian Kilger via GitGitGadget
2022-07-08 11:28 ` Tao Klerks
2022-07-08 15:05 ` Junio C Hamano
2022-07-18 8:57 ` [PATCH v2] " Kilian Kilger via GitGitGadget
2022-07-18 16:36 ` Junio C Hamano [this message]
2022-07-21 9:07 ` [PATCH v3 0/2] git-p4: Fix bug with encoding of P4 " Kilian Kilger via GitGitGadget
2022-07-21 9:07 ` [PATCH v3 1/2] git-p4: fix bug with encoding of p4 " Kilian Kilger via GitGitGadget
2022-07-21 9:07 ` [PATCH v3 2/2] git-p4: refactoring of p4CmdList() Kilian Kilger via GitGitGadget
2022-07-21 16:46 ` [PATCH v3 0/2] git-p4: Fix bug with encoding of P4 client name Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqcze2s7h0.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kkilger@gmail.com \
--cc=tao@klerks.biz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.