From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Elia Pinto <gitter.spiros@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Fixes compile warning with -Wimplicit-fallthrough CFLAGS
Date: Tue, 23 Jan 2018 10:33:57 -0800 [thread overview]
Message-ID: <xmqqd120ifvu.fsf@gitster.mtv.corp.google.com> (raw)
In-Reply-To: <20180123000727.GB26357@sigill.intra.peff.net> (Jeff King's message of "Mon, 22 Jan 2018 19:07:28 -0500")
Jeff King <peff@peff.net> writes:
>> diff --git a/apply.c b/apply.c
>> index 321a9fa68..a22fb2881 100644
>> --- a/apply.c
>> +++ b/apply.c
>> @@ -1450,7 +1450,7 @@ static void recount_diff(const char *line, int size, struct fragment *fragment)
>> switch (*line) {
>> case ' ': case '\n':
>> newlines++;
>> - /* fall through */
>> + GIT_FALLTHROUGH;
>
> Ugh, the semi-colon there makes it look like it's actual code. If we go
> this route, I wonder if it's worth hiding it inside the macro.
What? You mean to shout in all caps without even terminating the
line with any punctuation? Please don't---I am sure it will break
auto indentation people rely on from their editors.
next prev parent reply other threads:[~2018-01-23 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-22 23:51 [PATCH] Fixes compile warning with -Wimplicit-fallthrough CFLAGS Elia Pinto
2018-01-23 0:07 ` Jeff King
2018-01-23 18:33 ` Junio C Hamano [this message]
2018-01-23 18:37 ` Jeff King
2018-01-23 0:54 ` Eric Sunshine
2018-01-23 0:59 ` Jeff King
2018-01-23 6:31 ` Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd120ifvu.fsf@gitster.mtv.corp.google.com \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitter.spiros@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.