Re: [PATCH v13 2/6] test-parse-options: print quiet as integer

[Junio C Hamano <gitster@pobox.com>]

Pranit Bauva <pranit.bauva@gmail.com> writes:

> On Wed, Apr 13, 2016 at 3:03 AM, Junio C Hamano <gitster@pobox.com> wrote:
>> Pranit Bauva <pranit.bauva@gmail.com> writes:
>>
>>> Current implementation of parse-options.c treats OPT__QUIET() as integer
>>> and not boolean and thus it is more appropriate to print it as integer
>>> to avoid confusion.
>>
>> There is no "confusion" factor involved, as we do not use native
>> "boolean" type in our C code.  IIUC, the reason why we want to do
>> this is because we may want to see how it would affect the value of
>> the underlying variable to give multiple --quiet options from the
>> command line, which is a policy issue (i.e. we want to allow
>> commands to react to multiple quiet options differently), not an
>> implementation one (i.e. "current implementation happens to use
>> integer").
>>
>>         We would want to see how multiple --quiet options affect the
>>         value of the underlying variable (we may want "--quiet --quiet"
>>         to still be 1, or we may want to see the value incremented
>>         to 2).  Show the value as integer to allow us to inspect it.
>>
>> perhaps?
>
> This commit message does look a lot better. I will re-roll this.

You need to pick which one you want inside the (parentheses),
though.  After reading 3/6 I am guessing that that you wanted the
latter.

> Should I just send an update of this patch or the whole series?

The latter, for a series this small.

Thanks.