From: Junio C Hamano <gitster@pobox.com>
To: Michael Rappazzo <rappazzo@gmail.com>
Cc: davvid@gmail.com, ssaasen@atlassian.com, john@keeping.me.uk,
git@vger.kernel.org
Subject: Re: [PATCH] mergetools: add config option to disable auto-merge
Date: Wed, 17 Jun 2015 12:41:32 -0700 [thread overview]
Message-ID: <xmqqd20u6s2b.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1434490514-36204-2-git-send-email-rappazzo@gmail.com> (Michael Rappazzo's message of "Tue, 16 Jun 2015 17:35:14 -0400")
Michael Rappazzo <rappazzo@gmail.com> writes:
> For some mergetools, the current invocation of git mergetool will
> include an auto-merge flag. By default the flag is included, however if
> the git config option 'merge.automerge' is set to 'false', then that
> flag will now be omitted.
... and why is the "automerge" a bad thing that user would want to
avoid triggering under which condition? That description may not
have to be in the proposed log message, but it would help users when
they decide if they want to use the configuration to describe it in
the mergetool.automerge configuration.
And depending on the answer to the above question, a configuration
variable may turn out be a bad mechanism to customize this (namely,
set-and-forget configuration variable is a bad match for a knob that
is more "per invocation" than "user taste").
Is this not about "automerge" but more about "always-show-UI because
I like GUI?" Then that may be a "user taste" thing that is a good
match for a configuration variable. I simply cannot tell from what
was in the message I am responding to.
> -TEMPORARY FILES
> ----------------
> -`git mergetool` creates `*.orig` backup files while resolving merges.
> -These are safe to remove once a file has been merged and its
> -`git mergetool` session has completed.
> -
> +CONFIGURATION OPTIONS
> +---------------------
> +mergetool.keepBackup::
> + `git mergetool` creates `*.orig` backup files while resolving merges.
> + These are safe to remove once a file has been merged and its
> + `git mergetool` session has completed.
> ++
This is an unrelated change; I think it is a good change, though.
I however suspect that we would not want to repeat the configuration
description in this file and instead mention these in "see also"
section referring the readers to git-config(1).
next prev parent reply other threads:[~2015-06-17 19:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 21:35 [PATCH] mergetools: add config option to disable auto-merge Michael Rappazzo
2015-06-16 21:35 ` Michael Rappazzo
2015-06-17 19:41 ` Junio C Hamano [this message]
2015-06-18 2:27 ` Mike Rappazzo
2015-06-18 8:42 ` David Aguilar
2015-06-18 15:14 ` Mike Rappazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd20u6s2b.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=john@keeping.me.uk \
--cc=rappazzo@gmail.com \
--cc=ssaasen@atlassian.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.