All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>
Cc: git@vger.kernel.org, "René Scharfe" <l.s.r@web.de>,
	"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
	"Alex Zepeda" <alex@inferiorhumanorgans.com>,
	"Michael J Gruber" <git@drmicha.warpmail.net>
Subject: Re: [PATCH 0/3] Raw gpg output support for verify-commit and verify-tag
Date: Sun, 14 Jun 2015 14:23:47 -0700	[thread overview]
Message-ID: <xmqqd20ym1b0.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <1434307910-705555-1-git-send-email-sandals@crustytoothpaste.net> (brian m. carlson's message of "Sun, 14 Jun 2015 18:51:47 +0000")

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

> Currently, verify-commit and verify-tag produce human-readable output.
> This is great for humans, and awful for machines.  It also lacks a lot
> of the information that GnuPG's --status-fd output provides.
>
> For example, if you wanted to know
> * the hash algorithm;
> * whether the signature was made with a subkey; or
> * the OpenPGP signature version
> none of that information is available in the human-readable output.

What this series wants to achieve makes a lot of sense to me.  One
comment I have after skimming the patfches is that I want the new
"raw" bit added not as a yet another parameter after "verbose", but
by turning the existing "verbose" into an "unsigned flag" flag word
(with "#define GPG_VERIFY_VERBOSE 01") and then defining use of a
new bit in the same flag word "#define GPG_VERIFY_RAW 01" or
something.  That way, over time other people add differnt things to
the interface, we would not have to end up with 47 different
parameters each of which signals a single bit.

Thanks.

  parent reply	other threads:[~2015-06-14 21:24 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-14 18:51 [PATCH 0/3] Raw gpg output support for verify-commit and verify-tag brian m. carlson
2015-06-14 18:51 ` [PATCH 1/3] verify-commit: add option to print raw gpg status information brian m. carlson
2015-06-14 18:51 ` [PATCH 2/3] verify-tag: add tests brian m. carlson
2015-06-14 18:51 ` [PATCH 3/3] verify-tag: add option to print raw gpg status information brian m. carlson
2015-06-14 21:23 ` Junio C Hamano [this message]
2015-06-14 22:14   ` [PATCH 0/3] Raw gpg output support for verify-commit and verify-tag brian m. carlson
2015-06-15  8:22   ` Michael J Gruber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd20ym1b0.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=alex@inferiorhumanorgans.com \
    --cc=git@drmicha.warpmail.net \
    --cc=git@vger.kernel.org \
    --cc=l.s.r@web.de \
    --cc=pclouds@gmail.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.