From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Matthieu Moy <Matthieu.Moy@imag.fr>, git@vger.kernel.org
Subject: Re: [PATCH] Suggest applicants to participate in review of other peoples' patches
Date: Fri, 06 Mar 2015 13:57:40 -0800 [thread overview]
Message-ID: <xmqqd24lyejv.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20150306211048.GB24267@peff.net> (Jeff King's message of "Fri, 6 Mar 2015 16:10:48 -0500")
Jeff King <peff@peff.net> writes:
> On Fri, Mar 06, 2015 at 12:53:57PM +0100, Matthieu Moy wrote:
>
>> Idea and most of the wording comes from Junio's message on the list. I
>> added a hint to include links to review in the application (which makes
>> the suggestion a bit stronger since it implies that it will be taken into
>> account in the selection).
>
> Seems reasonable. I do not know what the quality of reviews will be from
> applicants, but I guess we will find out. :)
I actually was hoping to see an applicant replaying the review
comments given to him to another applicant that makes the same kind
of mistakes. That is a fairly easy entry to get into reviewing
process---even you may not yet know what you are suggesting the
other to do is the norm in this community, if a more experienced
person told you something similar, it would be likely it is.
next prev parent reply other threads:[~2015-03-06 21:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-06 7:44 GSoC applicants: discuss other applicants patches, perhaps? Junio C Hamano
2015-03-06 11:53 ` [PATCH] Suggest applicants to participate in review of other peoples' patches Matthieu Moy
2015-03-06 21:10 ` Jeff King
2015-03-06 21:57 ` Junio C Hamano [this message]
2015-03-08 10:10 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd24lyejv.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=Matthieu.Moy@imag.fr \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.