All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Ian Liu Rodrigues <ian.liu88@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: fix some typos in the preamble
Date: Mon, 15 Sep 2014 11:58:14 -0700	[thread overview]
Message-ID: <xmqqd2aw7ltl.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <CAD+ArX07pvmFKaCzy+dTcbga56U=fCgpPN-T3+QSudfFSVr=bQ@mail.gmail.com> (Ian Liu Rodrigues's message of "Sat, 13 Sep 2014 11:20:22 -0300")

Ian Liu Rodrigues <ian.liu88@gmail.com> writes:

> Signed-off-by: Ian Liu Rodrigues <ian.liu88@gmail.com>
> ---
>  Makefile | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Makefile b/Makefile
> index 9f984a9..496af55 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -14,11 +14,11 @@ all::
>  # Define INLINE to a suitable substitute (such as '__inline' or '') if git
>  # fails to compile with errors about undefined inline functions or similar.
>  #
> -# Define SNPRINTF_RETURNS_BOGUS if your are on a system which snprintf()
> +# Define SNPRINTF_RETURNS_BOGUS if you are on a system which snprintf()
>  # or vsnprintf() return -1 instead of number of characters which would

The change is correct but I wonder if "which snprintf()" should be
"whose snprintf()".

>  # have been written to the final string if enough space had been available.
>  #
> -# Define FREAD_READS_DIRECTORIES if your are on a system which succeeds
> +# Define FREAD_READS_DIRECTORIES if you are on a system which succeeds
>  # when attempting to read from an fopen'ed directory.
>  #
>  # Define NO_OPENSSL environment variable if you do not have OpenSSL.

Thanks.

      reply	other threads:[~2014-09-15 18:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-13 14:20 [PATCH] Makefile: fix some typos in the preamble Ian Liu Rodrigues
2014-09-15 18:58 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd2aw7ltl.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ian.liu88@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.