From: Junio C Hamano <gitster@pobox.com>
To: Dennis Kaarsemaker <dennis@kaarsemaker.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Makefile: don't hardcode HEAD in dist target
Date: Mon, 02 Jun 2014 13:27:14 -0700 [thread overview]
Message-ID: <xmqqd2er3vml.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20140602193419.GA10198@spirit> (Dennis Kaarsemaker's message of "Mon, 2 Jun 2014 21:34:20 +0200")
Dennis Kaarsemaker <dennis@kaarsemaker.net> writes:
> I'd say it would make the consistency better, because now both look at
> what is checked out instead of at HEAD.
The version with your patch does not even look at HEAD; it looks at
whatever GIT_VERSION points at, which could be a very different
version that does not have anything to do with what is checked out
Can't GIT_VERSION come from ./version file, for example?
prev parent reply other threads:[~2014-06-02 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-31 20:25 [PATCH] Makefile: don't hardcode HEAD in dist target Dennis Kaarsemaker
2014-06-02 18:53 ` Junio C Hamano
2014-06-02 19:34 ` Dennis Kaarsemaker
2014-06-02 20:27 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqd2er3vml.fsf@gitster.dls.corp.google.com \
--to=gitster@pobox.com \
--cc=dennis@kaarsemaker.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.