All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Roman Kagan <rkagan@mail.ru>
Cc: git@vger.kernel.org, Eric Wong <normalperson@yhbt.net>
Subject: Re: [PATCH 1/3] git-svn: use POSIX::sigprocmask to block signals
Date: Mon, 23 Apr 2012 14:13:51 -0700	[thread overview]
Message-ID: <xmqqd36yi228.fsf@junio.mtv.corp.google.com> (raw)
In-Reply-To: <CANiYKX68AJyE3+3BT7QSjziGS=HGKuk95rxS_04c0sGz9pywXw@mail.gmail.com> (Roman Kagan's message of "Tue, 24 Apr 2012 01:07:23 +0400")

Roman Kagan <rkagan@mail.ru> writes:

> [B]locking some signals is obviously not a good enough
> protection measure: the program may die on SIGKILL or the power may go
> off.

Ahh, that is what you meant.  I agree that it is of dubious value to
only try to catch signals, even though it may be better than nothing.

It should be sufficient to replace the "[...]" part with the above,
and conclude it with "But it will be a separate topic that this patch
does not address." or something.

Thanks.

  reply	other threads:[~2012-04-23 21:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23 16:35 [PATCH 0/3] git-svn: fixes for intermittent SIGPIPE Roman Kagan
2012-04-02 13:29 ` [PATCH 1/3] git-svn: use POSIX::sigprocmask to block signals Roman Kagan
2012-04-23 17:33   ` Junio C Hamano
2012-04-23 21:07     ` Roman Kagan
2012-04-23 21:13       ` Junio C Hamano [this message]
2012-04-02 13:52 ` [PATCH 2/3] git-svn: ignore SIGPIPE Roman Kagan
2012-04-23 16:26 ` [PATCH 3/3] git-svn: drop redundant blocking of SIGPIPE Roman Kagan
  -- strict thread matches above, loose matches on Subject: below --
2012-04-24  6:53 [PATCH 0/3] git-svn: fixes for intermittent SIGPIPE Roman Kagan
2012-04-02 13:29 ` [PATCH 1/3] git-svn: use POSIX::sigprocmask to block signals Roman Kagan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqd36yi228.fsf@junio.mtv.corp.google.com \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    --cc=rkagan@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.