All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,  Okhuomon Ajayi <okhuomonajayi54@gmail.com>,
	Srujith A Poojary <poojarysrujith@gmail.com>
Subject: Re: [PATCH v6] submodule: use the submodule repository to abbreviate commits
Date: Thu, 05 Nov 2026 07:20:21 -0800	[thread overview]
Message-ID: <xmqqecczxq2y.fsf@gitster.g> (raw)
In-Reply-To: <pull.2288.v6.git.1793821554097.gitgitgadget@gmail.com> (Srujith A. Poojary via GitGitGadget's message of "Wed, 04 Nov 2026 19:45:54 +0000")

"Srujith A Poojary via GitGitGadget" <gitgitgadget@gmail.com>
writes:

> Range-diff vs v5:
>
>  1:  f94aa2476f ! 1:  01c3cc2573 submodule: use the submodule repository to abbreviate commits
>      @@ Commit message
>           Use the submodule repository when it is available, and fall back
>           to the repository from the diff options when it is not.
>       
>      -    The expected abbreviation for a submodule commit depends on the
>      -    repository's hash algorithm. Use test_oid_cache to provide the
>      -    expected value for each algorithm and remove the SHA1 prerequisite
>      -    so this test runs with both SHA-1 and SHA-256.
>      +    As the expected abbreviation depends on the hash algorithm used,
>      +    the test uses the test_oid mechanism to switch the expectation
>      +    between SHA-1 and SHA-256 repositories.
>       
>           Signed-off-by: Srujith A Poojary <poojarysrujith@gmail.com>

Very good.  The patch text was already good at v4 and hasn't changed
since then.

Let's queue and mark it as ready for 'next'.

Thanks.

  reply	other threads:[~2026-11-05 15:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-31  8:25 [PATCH] [Outreachy PATCH] t4041: use submodule repository for commit abbreviations Srujith A Poojary via GitGitGadget
2026-10-31 16:46 ` Okhuomon Ajayi
2026-10-31 19:08   ` Srujith Poojary
2026-10-31 18:57 ` [PATCH v2] Submodule: use the submodule repository to abbreviate commits Srujith A Poojary via GitGitGadget
2026-10-31 19:09   ` Okhuomon Ajayi
2026-10-31 19:37     ` Srujith Poojary
2026-10-31 19:24 ` [PATCH v3] submodule: " Srujith A Poojary via GitGitGadget
2026-11-01 21:45   ` Junio C Hamano
2026-11-02 19:40 ` [PATCH v4 0/2] [Outreachy PATCH] t4041: use submodule repository for commit abbreviations Srujith A Poojary via GitGitGadget
2026-11-02 19:40   ` [PATCH v4 1/2] submodule: use the submodule repository to abbreviate commits Srujith A Poojary via GitGitGadget
2026-11-02 19:49     ` Srujith Poojary
2026-11-02 19:40   ` [PATCH v4 2/2] t4041: test SHA-256 submodule abbreviations Srujith A Poojary via GitGitGadget
2026-11-03 17:31     ` Junio C Hamano
2026-11-04  3:58       ` Srujith Poojary
2026-11-03 17:27   ` [PATCH v4 0/2] [Outreachy PATCH] t4041: use submodule repository for commit abbreviations Junio C Hamano
2026-11-04  3:43 ` [PATCH v5] submodule: use the submodule repository to abbreviate commits Srujith A Poojary via GitGitGadget
2026-11-04 14:38   ` Junio C Hamano
2026-11-04 19:45 ` [PATCH v6] " Srujith A Poojary via GitGitGadget
2026-11-05 15:20   ` Junio C Hamano [this message]
2026-11-06 18:14     ` Srujith Poojary

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqecczxq2y.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=okhuomonajayi54@gmail.com \
    --cc=poojarysrujith@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.