From: Junio C Hamano <gitster@pobox.com>
To: Taylor Blau <ttaylorr@openai.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/5] packfile: harden handling of packs with duplicate entries
Date: Fri, 24 Jul 2026 14:54:17 -0700 [thread overview]
Message-ID: <xmqqecgs3vg6.fsf@gitster.g> (raw)
In-Reply-To: <cover.1784927134.git.ttaylorr@openai.com> (Taylor Blau's message of "Fri, 24 Jul 2026 16:05:44 -0500")
Taylor Blau <ttaylorr@openai.com> writes:
> Packfiles containing duplicate object entries are unusual, but Git
> already accepts them outside of strict indexing.
That is looser than what we intended. "unusual" -> "invalid". It
is just like Git does not immediately complain until "git fsck",
"git repack", or otherwise "git" tries to use the object if you
corrupted loose object files under .git/objects/??/ directories.
Detecting such a problematic pack early before the problem spreads
is a very welcome change.
prev parent reply other threads:[~2026-07-24 21:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 21:05 [PATCH 0/5] packfile: harden handling of packs with duplicate entries Taylor Blau
2026-07-24 21:05 ` [PATCH 1/5] t5308: test reverse indexes with duplicate objects Taylor Blau
2026-07-24 21:06 ` [PATCH 2/5] packfile: recover delta cycles through duplicate entries Taylor Blau
2026-07-24 21:06 ` [PATCH 3/5] midx: verify duplicate pack entries by OID and offset Taylor Blau
2026-07-24 21:06 ` [PATCH 4/5] test-tool bitmap: reject packs with duplicate objects Taylor Blau
2026-07-24 21:06 ` [PATCH 5/5] pack-bitmap: handle duplicate pack entries during MIDX reuse Taylor Blau
2026-07-24 21:54 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqecgs3vg6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ttaylorr@openai.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.