From: Junio C Hamano <gitster@pobox.com>
To: Weijie Yuan <wy@wyuan.org>
Cc: Derrick Stolee <stolee@gmail.com>,
Kristofer Karlsson via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org, Kristofer Karlsson <krka@spotify.com>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v2] commit-reach: remove get_reachable_subset()
Date: Fri, 12 Jun 2026 07:41:48 -0700 [thread overview]
Message-ID: <xmqqecibizwz.fsf@gitster.g> (raw)
In-Reply-To: <aivQv5FkTEWDn22i@wyuan.org> (Weijie Yuan's message of "Fri, 12 Jun 2026 17:26:23 +0800")
Weijie Yuan <wy@wyuan.org> writes:
> On Thu, Jun 11, 2026 at 10:48:18AM -0700, Junio C Hamano wrote:
>> I wonder if we should talk about it in the SubmittingPatches and/or
>> MyFirstContribution document?
>
> Hi, I think it might be a good idea to cover these details in
> MyFirstContribution, then cross-reference them from the part of
> SubmittingPatches that discusses sending a new version.
Sorry to be nitpicky, but the above is omitting too much from your
quote. "it" in "talk about it" is totally unclear to a reader who
haven't seen the message you are replying to.
> Also, for the part about sending a new version, I wonder whether it
> would be better to summarize and fold in Patrick's explanation here,
> thank you Patrick:
Yup, that is a great example.
> From: Patrick Steinhardt <ps@pks.im>
> Message-ID: <aietF4BX1Ewt3cpG@pks.im>
next prev parent reply other threads:[~2026-06-12 14:41 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 19:28 [PATCH] commit-reach: remove get_reachable_subset() Kristofer Karlsson via GitGitGadget
2026-06-10 15:48 ` Junio C Hamano
2026-06-10 18:25 ` Kristofer Karlsson
2026-06-10 19:29 ` Derrick Stolee
2026-06-11 11:49 ` [PATCH v2] " Kristofer Karlsson via GitGitGadget
2026-06-11 12:57 ` Derrick Stolee
2026-06-11 13:52 ` Kristofer Karlsson
2026-06-11 14:51 ` Derrick Stolee
2026-06-11 17:48 ` Junio C Hamano
2026-06-12 9:26 ` Weijie Yuan
2026-06-12 14:41 ` Junio C Hamano [this message]
2026-06-12 16:16 ` Weijie Yuan
2026-06-12 16:21 ` Weijie Yuan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqecibizwz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=krka@spotify.com \
--cc=ps@pks.im \
--cc=stolee@gmail.com \
--cc=wy@wyuan.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.