From: Junio C Hamano <gitster@pobox.com>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: Francesco Paparatto <francescopaparatto@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH v4] t3310: avoid hiding failures from rev-parse in command substitutions
Date: Sat, 07 Mar 2026 22:04:12 -0800 [thread overview]
Message-ID: <xmqqecluuaar.fsf@gitster.g> (raw)
In-Reply-To: <CAPig+cTmRGBjV=yG4PvyyvFOgTZ0zK4GtkiO1xGSm1+OeM4ScQ@mail.gmail.com> (Eric Sunshine's message of "Sat, 7 Mar 2026 23:13:00 -0500")
Eric Sunshine <sunshine@sunshineco.com> writes:
>> @@ -569,13 +578,15 @@ EOF
>> - test_grep -q "$(git rev-parse refs/notes/m)" output &&
>> - test_grep -q "$(git rev-parse NOTES_MERGE_PARTIAL^1)" output &&
>> + oid=$(git rev-parse refs/notes/m) &&
>> + test_grep -q "$oid" output &&
>> + oid=$(git rev-parse NOTES_MERGE_PARTIAL^1) &&
>> + test_grep -q "$oid" output &&
>> @@ -606,8 +617,8 @@ test_expect_success 'switch cwd before committing notes merge' '
>> - echo "foo" > $(git rev-parse HEAD) &&
>> - echo "bar" >> $(git rev-parse HEAD) &&
>> + oid=$(git rev-parse HEAD) &&
>> + test_write_lines foo bar >"$oid" &&
>
> Thank you, this version (v4) looks good; it addresses all my review
> comments. For what it's worth:
>
> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com>
Yup, looking good.
prev parent reply other threads:[~2026-03-08 6:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-04 12:19 [PATCH] t3310: avoid hiding failures from rev-parse in command substitutions Francesco Paparatto
2026-03-04 22:21 ` Eric Sunshine
2026-03-05 9:06 ` [PATCH v2] " Francesco Paparatto
2026-03-05 19:13 ` Junio C Hamano
2026-03-05 22:34 ` Eric Sunshine
2026-03-05 22:49 ` Francesco Paparatto
2026-03-05 23:06 ` Junio C Hamano
2026-03-05 23:14 ` Junio C Hamano
2026-03-05 22:42 ` Francesco Paparatto
2026-03-05 22:51 ` [PATCH v3] " Francesco Paparatto
2026-03-07 6:29 ` Eric Sunshine
2026-03-07 10:17 ` Francesco Paparatto
2026-03-07 10:36 ` [PATCH v4] " Francesco Paparatto
2026-03-08 4:13 ` Eric Sunshine
2026-03-08 6:04 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqecluuaar.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=francescopaparatto@gmail.com \
--cc=git@vger.kernel.org \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.