From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: Toon Claes <toon@iotcl.com>,
git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH 2/2] contrib/coccinelle: pass include paths to spatch(1)
Date: Fri, 12 Dec 2025 14:04:58 +0900 [thread overview]
Message-ID: <xmqqecp0cmth.fsf@gitster.g> (raw)
In-Reply-To: <aTpieqFoMmZiSzWS@pks.im> (Patrick Steinhardt's message of "Thu, 11 Dec 2025 07:19:38 +0100")
Patrick Steinhardt <ps@pks.im> writes:
>> # For the 'coccicheck' target
>> -SPATCH_INCLUDE_FLAGS = --all-includes
>> +SPATCH_INCLUDE_FLAGS = --all-includes $(addprefix -I ,compat ewah refs sha256 trace2 win32 xdiff)
>
> This feels weird to me. We never pass any of these includes to the
> compiler, either. So why should Coccinelle require them?
>
> Coming back to your example of `eword_t`, Git knows to always include
> "ewah/ewok.h", and that include is relative to the root directory of Git
> itself. And as the header doesn't have any includes itself, this cannot
> be the root cause, either.
>
> So I'm a bit puzzled why this patch would fix the observed issue.
Indeed it is puzzling..
next prev parent reply other threads:[~2025-12-12 5:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-10 13:13 [PATCH 0/2] Add MEMZERO_ARRAY() macro and use it in coccinelle Toon Claes
2025-12-10 13:13 ` [PATCH 1/2] git-compat-util: introduce MEMZERO_ARRAY() macro Toon Claes
2025-12-11 3:18 ` Junio C Hamano
2025-12-12 13:02 ` René Scharfe
2025-12-19 9:17 ` Toon Claes
2025-12-10 13:13 ` [PATCH 2/2] contrib/coccinelle: pass include paths to spatch(1) Toon Claes
2025-12-11 6:19 ` Patrick Steinhardt
2025-12-12 5:04 ` Junio C Hamano [this message]
2025-12-13 1:22 ` Junio C Hamano
2025-12-13 0:18 ` [PATCH 0/2] Add MEMZERO_ARRAY() macro and use it in coccinelle Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqecp0cmth.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=ps@pks.im \
--cc=toon@iotcl.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.