From: Junio C Hamano <gitster@pobox.com>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: git@vger.kernel.org, Jacob Keller <jacob.keller@gmail.com>,
Lidong Yan <yldhome2d2@gmail.com>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH v3 1/7] remote: remove branch->merge_name and fix branch_release()
Date: Fri, 20 Jun 2025 16:36:00 -0700 [thread overview]
Message-ID: <xmqqecve0yvz.fsf@gitster.g> (raw)
In-Reply-To: <20250618-jk-submodule-helper-use-url-v3-1-7c60f2679271@gmail.com> (Jacob Keller's message of "Wed, 18 Jun 2025 16:08:15 -0700")
Jacob Keller <jacob.e.keller@intel.com> writes:
> This end result is cleaner, and avoids duplicating the merge names
> twice.
>
> Signed-off-by: Jacob Keller <jacob.keller@gmail.com>
> Link: [1] https://lore.kernel.org/git/20250617-jk-submodule-helper-use-url-v2-1-04cbb003177d@gmail.com/
> ---
> remote.h | 4 ++--
> branch.c | 4 ++--
> builtin/pull.c | 2 +-
> remote.c | 42 +++++++++++++++++++++++++++---------------
> 4 files changed, 32 insertions(+), 20 deletions(-)
This unfortunately makes t5582 segfault.
next prev parent reply other threads:[~2025-06-20 23:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-18 23:08 [PATCH v3 0/7] submodule: improve remote lookup logic Jacob Keller
2025-06-18 23:08 ` [PATCH v3 1/7] remote: remove branch->merge_name and fix branch_release() Jacob Keller
2025-06-20 23:36 ` Junio C Hamano [this message]
2025-06-21 2:12 ` Lidong Yan
2025-06-23 23:06 ` Jacob Keller
2025-06-18 23:08 ` [PATCH v3 2/7] remote: fix tear down of struct remote Jacob Keller
2025-06-18 23:08 ` [PATCH v3 3/7] dir: move starts_with_dot(_dot)_slash to dir.h Jacob Keller
2025-06-18 23:08 ` [PATCH v3 4/7] remote: remove the_repository from some functions Jacob Keller
2025-06-18 23:08 ` [PATCH v3 5/7] submodule--helper: improve logic for fallback remote name Jacob Keller
2025-06-18 23:08 ` [PATCH v3 6/7] submodule: move get_default_remote_submodule() Jacob Keller
2025-06-18 23:08 ` [PATCH v3 7/7] submodule: look up remotes by URL first Jacob Keller
2025-06-18 23:33 ` [PATCH v3 0/7] submodule: improve remote lookup logic Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqecve0yvz.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jacob.keller@gmail.com \
--cc=ps@pks.im \
--cc=yldhome2d2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.