All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Eric Wong <e@80x24.org>,
	Phillip Wood <phillip.wood@dunelm.org.uk>
Subject: Re: [PATCH] start_command: reset disposition of all signals in child
Date: Fri, 08 Sep 2023 08:42:06 -0700	[thread overview]
Message-ID: <xmqqedj8vfht.fsf@gitster.g> (raw)
In-Reply-To: <pull.1582.git.1694167540231.gitgitgadget@gmail.com> (Phillip Wood via GitGitGadget's message of "Fri, 08 Sep 2023 10:05:40 +0000")

"Phillip Wood via GitGitGadget" <gitgitgadget@gmail.com> writes:

> [3] This is really a work-around for not moving the child into its own
>     process group and changing the foreground process group of the
>     controlling terminal.

I am puzzled, as I somehow thought that "does the user conceive a
subprocess as external and different-from-git entity, or is it
merely an implementation detail?  many use of subprocesses in our
codebase, it is the latter." from Peff was a good argument against
such isolation between spawning "git" and spawned subprocesses.

  reply	other threads:[~2023-09-08 15:42 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 10:05 [PATCH] start_command: reset disposition of all signals in child Phillip Wood via GitGitGadget
2023-09-08 15:42 ` Junio C Hamano [this message]
2023-09-08 15:53   ` Phillip Wood
2023-09-08 16:24     ` Junio C Hamano
2023-09-08 16:43       ` Phillip Wood
2023-09-08 17:38         ` Junio C Hamano
2023-09-11  9:50           ` Phillip Wood
2023-09-11 22:20             ` Junio C Hamano
2023-09-08 19:57 ` Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedj8vfht.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=e@80x24.org \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.