All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Drew DeVault <sir@cmpwn.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] builtin/log.c: prepend "RFC" on --rfc
Date: Mon, 28 Aug 2023 08:31:46 -0700	[thread overview]
Message-ID: <xmqqedjnji8t.fsf@gitster.g> (raw)
In-Reply-To: <20230828125132.25144-1-sir@cmpwn.com> (Drew DeVault's message of "Mon, 28 Aug 2023 14:50:34 +0200")

Drew DeVault <sir@cmpwn.com> writes:

> Rather than replacing the configured subject prefix (either through the
> git config or command line) entirely with "RFC PATCH", this change
> prepends RFC to whatever subject prefix was already in use.
>
> This is useful, for example, when a user is working on a repository that
> has a subject prefix considered to disambiguate patches:
>
> 	git config format.subjectPrefix 'PATCH my-project'
>
> Prior to this change, formatting patches with --rfc would lose the
> 'my-project' information.

OK.  

My initial reaction was that we should just deprecate "--rfc" and
instead use "--subject-prefix" for whatever multi-token string; that
way, we do not need to worry about having to add "--wip" and other
"shorthand" options ;-).  But the combination of the configuration
variable that specifies the tag that is used for everyday operation
and a command line option that allows you to add (not replace) RFC
would be a justifiable behaviour.  It certainly is better than the
current (original) design of "--rfc".  This needs to be advertised
as a backward incompatible change in the release notes, but I doubt
that the fallout would be major.

The implementation below looks like it is quite out of our style,
but I'll read v2 instead.


      parent reply	other threads:[~2023-08-28 15:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-28 12:50 [PATCH] builtin/log.c: prepend "RFC" on --rfc Drew DeVault
2023-08-28 14:42 ` Jeff King
2023-08-28 14:49   ` Drew DeVault
2023-08-28 16:30   ` Phillip Wood
2023-08-28 17:42     ` Jeff King
2023-08-28 18:12     ` Junio C Hamano
2023-08-28 15:31 ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedjnji8t.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sir@cmpwn.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.