From: Junio C Hamano <gitster@pobox.com>
To: Adam Majer <adamm@zombino.com>
Cc: git@vger.kernel.org
Subject: Re: SHA256 support not experimental, or?
Date: Wed, 26 Jul 2023 09:44:05 -0700 [thread overview]
Message-ID: <xmqqedkuei7e.fsf@gitster.g> (raw)
In-Reply-To: <xmqqr0p230rj.fsf@gitster.g> (Junio C. Hamano's message of "Thu, 20 Jul 2023 11:18:08 -0700")
Junio C Hamano <gitster@pobox.com> writes:
> Adam Majer <adamm@zombino.com> writes:
>
>> I'll try again with inline patch.
>>
>> From 90be51143e741053390810720ba4a639c3b0b74c Mon Sep 17 00:00:00 2001
>
> Remove all the above lines (including the "From <commit object
> ...
>> Signed-off-by: Adam Majer <adamm@zombino.com>
>> ---
>> Documentation/git.txt | 4 ++--
>> Documentation/object-format-disclaimer.txt | 8 ++------
>> 2 files changed, 4 insertions(+), 8 deletions(-)
>> ...
> This side looks OK (just removing the single sentence).
>
>> Git Commits
>> ~~~~~~~~~~~
>> diff --git a/Documentation/object-format-disclaimer.txt b/Documentation/object-format-disclaimer.txt
>> index 4cb106f0d1..1e976688be 100644
>> --- a/Documentation/object-format-disclaimer.txt
>> +++ b/Documentation/object-format-disclaimer.txt
>> @@ -1,6 +1,2 @@
>> ...
>
> The original did not have this problem because it had enough
> surrounding context, but the updated text now risks getting misread
> as if there are "regular" and "special" SHA-1 repositories, the
> latter of which might work better with SHA-256.
>
> And the message about SHA-256's non-experimental status can probably
> be a lot stronger, after the discussion we had recently. How about
> saying something like:
>
> Note: there is no interoperability between SHA-256 repositories
> and SHA-1 repositories right now. We historically warned that
> SHA-256 repositories may need backward incompatible changes
> later when we introduce such interoperability features, but at
> this point we do not expect that we need to make such a change
> when we do so, and the users can expect that their SHA-256
> repositories they create with today's Git will be usable by
> future versions of Git without losing information.
>
> which would probably be much closer to what you wanted to hear?
It has been a week. Any news on this topic?
Thanks.
next prev parent reply other threads:[~2023-07-26 16:44 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 16:28 SHA256 support not experimental, or? Adam Majer
2023-06-29 1:59 ` brian m. carlson
2023-06-29 10:42 ` Adam Majer
2023-06-29 5:59 ` Junio C Hamano
2023-06-29 10:53 ` Adam Majer
2023-06-29 20:56 ` Junio C Hamano
2023-06-29 21:17 ` brian m. carlson
2023-06-29 22:22 ` Junio C Hamano
2023-06-30 1:21 ` brian m. carlson
2023-06-30 9:31 ` Patrick Steinhardt
2023-06-30 11:25 ` Adam Majer
2023-06-30 11:38 ` Patrick Steinhardt
2023-06-30 12:20 ` Son Luong Ngoc
2023-06-30 16:45 ` Junio C Hamano
2023-07-20 15:07 ` Adam Majer
2023-07-20 18:18 ` Junio C Hamano
2023-07-26 16:44 ` Junio C Hamano [this message]
2023-07-31 13:38 ` Adam Majer
2023-07-31 13:42 ` [PATCH] doc: sha256 is no longer experimental Adam Majer
2023-07-31 16:01 ` Junio C Hamano
2023-07-31 16:44 ` Adam Majer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedkuei7e.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=adamm@zombino.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.