All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] delta-islands: fix segfault when freeing island marks
Date: Tue, 21 Feb 2023 09:15:29 -0800	[thread overview]
Message-ID: <xmqqedqjgcsu.fsf@gitster.g> (raw)
In-Reply-To: <Y/MjdRq2dTbqh0a/@ncase> (Patrick Steinhardt's message of "Mon, 20 Feb 2023 08:38:29 +0100")

Patrick Steinhardt <ps@pks.im> writes:

> Oops, right. Please feel free to add it when pulling:
>
>     Signed-off-by: Patrick Steinhardt <ps@pks.im>

I'll add that to the copy I already have.

> If you prefer I'd also be happy to send another iteration of this patch,
> potentially including a direct test for git-pack-objects(1). I'm still
> not sure whether it'd be worth it though given that it's implicitly
> covered by the higher-level test that checks for the segfault by using
> git-multi-pack-index(1).

The existing test probably is sufficient.

Thanks.

  reply	other threads:[~2023-02-21 17:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-16 10:29 [PATCH] delta-islands: fix segfault when freeing island marks Patrick Steinhardt
2023-02-16 12:08 ` Eric Wong
2023-02-16 17:36 ` Junio C Hamano
2023-02-20  7:38   ` Patrick Steinhardt
2023-02-21 17:15     ` Junio C Hamano [this message]
2023-02-16 18:01 ` Junio C Hamano
2023-02-20  7:34   ` Patrick Steinhardt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedqjgcsu.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=ps@pks.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.