All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Philip Oakley <philipoakley@iee.email>
Cc: git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18))
Date: Mon, 21 Nov 2022 09:37:19 +0900	[thread overview]
Message-ID: <xmqqedtxywg0.fsf@gitster.g> (raw)
In-Reply-To: <8791cb85-cf4a-4302-5c1a-54a7e7766cfb@iee.email> (Philip Oakley's message of "Sun, 20 Nov 2022 17:42:43 +0000")

Philip Oakley <philipoakley@iee.email> writes:

> Ping, Hopefully an easy single patch review for someone on-list.
>
> Potential review points:
>
> Is the commit message sufficient?
> Are the tests: Sufficient, Complete, Correct ?
> Is `qz_to_tab_space` conversion applied correctly?

Is the feature and the design sensible?

Are the tests checking interesting cases?  The underlying mechanism
uses strbuf_utf8_replace() because there are character strings whose
display columns do not match their byte length (otherwise you can
just use strlen() and chomp at byte boundary), so a test whose
result would be different if strbuf_utf8_replace() were replaced
with a more naive strbuf_splice() would be valuable and meaningful.

  reply	other threads:[~2022-11-21  0:37 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19  2:22 What's cooking in git.git (Nov 2022, #04; Fri, 18) Taylor Blau
2022-11-20 11:24 ` SZEDER Gábor
2022-11-20 17:42 ` Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18)) Philip Oakley
2022-11-21  0:37   ` Junio C Hamano [this message]
2022-11-21 18:10     ` Philip Oakley
2022-11-20 19:46 ` What's cooking in git.git (Nov 2022, #04; Fri, 18) Phillip Wood
2022-11-20 21:24   ` Johannes Schindelin
2022-11-21  0:47     ` Junio C Hamano
2022-11-21  1:00       ` Taylor Blau
2022-11-22 14:58     ` Phillip Wood
2022-11-20 21:45 ` Junio C Hamano
2022-11-20 23:51   ` Taylor Blau
2022-11-20 23:24 ` Junio C Hamano
2022-11-20 23:52   ` Taylor Blau
2022-11-21  3:36     ` Junio C Hamano
2022-11-22 22:56       ` Taylor Blau
2022-11-21  0:10 ` Junio C Hamano
2022-11-21  0:16   ` Taylor Blau
2022-11-23  0:03     ` Junio C Hamano
2022-11-21 22:22 ` ab/submodule-no-abspath (was Re: What's cooking in git.git (Nov 2022, #04; Fri, 18)) Glen Choo
2022-11-22 22:45   ` [PATCH] submodule absorbgitdirs: use relative <from> and <to> paths Ævar Arnfjörð Bjarmason
2022-11-23  0:43     ` Glen Choo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqedtxywg0.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=me@ttaylorr.com \
    --cc=philipoakley@iee.email \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.