From: Junio C Hamano <gitster@pobox.com>
To: "Rubén Justo" <rjusto@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
"Erlend E. Aasland" <erlend.aasland@innova.no>,
Ivan Tham <pickfire@riseup.net>,
Aaron Greenberg <p@aaronjgreenberg.com>,
Elena Petrashen <elena.petrashen@gmail.com>,
Dinesh <dpdineshp2@gmail.com>,
Kenny Lee Sin Cheong <kenny.lee28@gmail.com>
Subject: Re: [PATCH v4] branch: allow "-" as a shortcut for "previous branch"
Date: Mon, 12 Sep 2022 10:52:04 -0700 [thread overview]
Message-ID: <xmqqedwgfpkr.fsf@gitster.g> (raw)
In-Reply-To: <dbc0b0d8-4b0a-8d4c-1bfa-8bdcd99310e7@gmail.com> ("Rubén Justo"'s message of "Sun, 11 Sep 2022 16:14:55 +0200")
Rubén Justo <rjusto@gmail.com> writes:
> Teach "git branch" the use of "-" as a shortcut for "@{-1}", like in "checkout
> -", "merge -" and other commands.
I am sorry that this is now at v4, but let's not do this.
"git checkout -" was started purely because "cd -" is a fairly well
known way to say "go back to the previous directory" (it is "cd ~-"
in some shells).
No shells accept "mv - newname" to rename the directory we were
previously in, or "rmdir -" to remove it. And "diff -r - ." does
not compare the previous and the current directory recursively.
But all of these can be done (with some shells) if you use a proper
syntax, "mv ~- newname", "rmdir ~-", or "diff -r ~- .".
Yes, we may have by mistake added "git merge -" as well, but it is
perfectly fine to say that we should admit it as a mistake and plan
to possibly deprecate it in the longer term. We shouldn't use it as
an excuse to make things even more confusing.
Thanks. I think your other "git branch -d @{-1}" thing is sound,
though.
next prev parent reply other threads:[~2022-09-12 17:52 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-07 22:22 [PATCH] branch: allow "-" as a short-hand for "previous branch" Rubén Justo via GitGitGadget
2022-08-08 13:26 ` Johannes Schindelin
2022-08-08 16:06 ` Junio C Hamano
2022-08-13 9:19 ` Rubén Justo
2022-08-13 22:28 ` Junio C Hamano
2022-08-16 9:49 ` Johannes Schindelin
2022-08-19 13:05 ` Johannes Schindelin
2022-08-19 18:11 ` Junio C Hamano
2022-08-25 7:57 ` Rubén Justo
2022-08-25 16:23 ` Junio C Hamano
2022-08-25 19:50 ` Rubén Justo
2022-08-13 9:08 ` Rubén Justo
2022-08-08 14:46 ` Junio C Hamano
2022-08-13 9:14 ` Rubén Justo
2022-08-16 9:31 ` Johannes Schindelin
2022-08-16 17:03 ` Rubén Justo
2022-08-19 11:42 ` Johannes Schindelin
2022-08-16 17:11 ` [PATCH v2] allow "-" as short-hand for "@{-1}" in "branch -d" Rubén Justo via GitGitGadget
2022-08-16 18:55 ` Junio C Hamano
2022-08-16 21:27 ` Rubén Justo
2022-08-16 21:18 ` [PATCH v3] branch: allow "-" as a short-hand for "previous branch" Rubén Justo
2022-09-11 14:14 ` [PATCH v4] branch: allow "-" as a shortcut " Rubén Justo
2022-09-12 17:52 ` Junio C Hamano [this message]
2022-09-12 21:18 ` Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqedwgfpkr.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=dpdineshp2@gmail.com \
--cc=elena.petrashen@gmail.com \
--cc=erlend.aasland@innova.no \
--cc=git@vger.kernel.org \
--cc=kenny.lee28@gmail.com \
--cc=p@aaronjgreenberg.com \
--cc=pickfire@riseup.net \
--cc=rjusto@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.